From 30fcf6b46dbb29176147cd98d7a90f18d97c4162 Mon Sep 17 00:00:00 2001 From: Guy Daich Date: Thu, 22 Feb 2024 14:21:59 -0600 Subject: [PATCH] fix linting Signed-off-by: Guy Daich --- .../testdata/backendtrafficpolicy-with-retries.in.yaml | 8 ++++---- internal/xds/translator/route.go | 2 +- internal/xds/translator/testdata/in/xds-ir/retry.yaml | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/internal/gatewayapi/testdata/backendtrafficpolicy-with-retries.in.yaml b/internal/gatewayapi/testdata/backendtrafficpolicy-with-retries.in.yaml index 09799a558b7..6ed617254cc 100644 --- a/internal/gatewayapi/testdata/backendtrafficpolicy-with-retries.in.yaml +++ b/internal/gatewayapi/testdata/backendtrafficpolicy-with-retries.in.yaml @@ -98,11 +98,11 @@ backendTrafficPolicies: numRetries: 5 retryOn: httpStatusCodes: - - 429 - - 503 + - 429 + - 503 triggers: - - connect-failure - - retriable-status-codes + - connect-failure + - retriable-status-codes perRetry: timeout: 250ms backoff: diff --git a/internal/xds/translator/route.go b/internal/xds/translator/route.go index fe1c7432633..c711e64daf5 100644 --- a/internal/xds/translator/route.go +++ b/internal/xds/translator/route.go @@ -454,7 +454,7 @@ func buildRetryStatusCodes(codes []ir.HTTPStatus) []uint32 { return ret } -// buildRetryOn concatenates triggers to a comma-delimited list +// buildRetryOn concatenates triggers to a comma-delimited string. // An error is returned if a trigger is not in the list of supported values (not likely, due to prior validations). func buildRetryOn(triggers []ir.TriggerEnum) (string, error) { if len(triggers) == 0 { diff --git a/internal/xds/translator/testdata/in/xds-ir/retry.yaml b/internal/xds/translator/testdata/in/xds-ir/retry.yaml index 373bd00924d..80ddd60de50 100644 --- a/internal/xds/translator/testdata/in/xds-ir/retry.yaml +++ b/internal/xds/translator/testdata/in/xds-ir/retry.yaml @@ -14,11 +14,11 @@ http: numRetries: 5 retryOn: httpStatusCodes: - - 429 - - 503 + - 429 + - 503 triggers: - - connect-failure - - retriable-status-codes + - connect-failure + - retriable-status-codes perRetry: timeout: 250ms backoff: