From 80db45944e010a5ba8eb2636201450ffb1a59f8e Mon Sep 17 00:00:00 2001 From: Arko Dasgupta Date: Fri, 26 May 2023 11:39:03 -0700 Subject: [PATCH] fix: Run yamllint on generated Install Manifests (#1450) Run yamllint on generated Install Manifests Fixes: https://github.com/envoyproxy/gateway/issues/810 Signed-off-by: Arko Dasgupta --- .github/workflows/build_and_test.yaml | 3 +++ charts/gateway-helm/templates/certgen.yaml | 2 +- tools/linter/yamllint/.yamllint | 5 ++++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml index c98d69a2684..e35093912c5 100644 --- a/.github/workflows/build_and_test.yaml +++ b/.github/workflows/build_and_test.yaml @@ -18,6 +18,9 @@ jobs: steps: - uses: actions/checkout@v3 - uses: ./tools/github-actions/setup-deps + # Generate the install manifests first so it can checked + # for errors while running `make -k lint` + - run: make generate-manifests - run: make lint-deps - run: make -k lint diff --git a/charts/gateway-helm/templates/certgen.yaml b/charts/gateway-helm/templates/certgen.yaml index cfad73c055f..c1e9b16fd6d 100644 --- a/charts/gateway-helm/templates/certgen.yaml +++ b/charts/gateway-helm/templates/certgen.yaml @@ -29,7 +29,7 @@ spec: - name: KUBERNETES_CLUSTER_DOMAIN value: {{ .Values.kubernetesClusterDomain }} image: {{ .Values.deployment.envoyGateway.image.repository }}:{{ .Values.deployment.envoyGateway.image.tag | default .Chart.AppVersion }} - imagePullPolicy: {{ .Values.deployment.envoyGateway.imagePullPolicy }} + imagePullPolicy: {{ .Values.deployment.envoyGateway.imagePullPolicy }} name: envoy-gateway-certgen restartPolicy: Never securityContext: diff --git a/tools/linter/yamllint/.yamllint b/tools/linter/yamllint/.yamllint index 56d91fd6498..1d944440e84 100644 --- a/tools/linter/yamllint/.yamllint +++ b/tools/linter/yamllint/.yamllint @@ -1,8 +1,11 @@ --- ignore: | + # This directory fails checks since many files + # are templated. Instead, we run the linter + # after running `make generate-manifests` which creates + # the Install YAML in bin/ charts/gateway-helm/ - bin/install.yaml rules: braces: