Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Metrics instrumentation #2092

Closed
18 of 19 tasks
Xunzhuo opened this issue Oct 27, 2023 · 6 comments · Fixed by #3463
Closed
18 of 19 tasks

Implement Metrics instrumentation #2092

Xunzhuo opened this issue Oct 27, 2023 · 6 comments · Fixed by #3463
Assignees
@shawnh2
Labels
area/observability Observability related issues kind/enhancement New feature or request road-to-ga
Milestone
v1.1.0-rc1

Comments

@Xunzhuo
Copy link
Member

Xunzhuo commented Oct 27, 2023 •
edited by arkodg
Loading

Description:

Do metrics instrumentation in EG components:

  • Provider:
    • controller-runtime metrics
    • watchable map metrics
  • GWAPI-Translator
    • watchable map metrics
  • xDS-Translator
    • watchable map metrics
  • xDS-Server
    • watchable map metrics
    • xds server metrics
  • Infra-Manager
    • watchable map metrics
    • infra-manager metrics
  • Status Updater

Implement Metrics instrumentation for EG CP Observability.
@Xunzhuo Xunzhuo added kind/enhancement New feature or request area/observability Observability related issues labels Oct 27, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Nov 30, 2023
@Xunzhuo Xunzhuo added this to the v1.0.0-rc1 milestone Dec 7, 2023
@github-actions github-actions bot removed the stale label Dec 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Jan 6, 2024
@arkodg
Copy link
Contributor

arkodg commented Feb 15, 2024

@Xunzhuo still planning on working on this for v1.0 ?

@github-actions github-actions bot removed the stale label Feb 15, 2024
@Xunzhuo Xunzhuo modified the milestones: v1.0.0-rc1, Backlog Feb 28, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Mar 29, 2024
@Xunzhuo Xunzhuo added the help wanted Extra attention is needed label Mar 29, 2024
@shawnh2 shawnh2 mentioned this issue Apr 29, 2024
Closed
6 tasks
@shawnh2 shawnh2 self-assigned this Apr 29, 2024
@shawnh2 shawnh2 removed help wanted Extra attention is needed stale labels Apr 29, 2024
@shawnh2
Copy link
Contributor

shawnh2 commented Apr 29, 2024 •
edited
Loading

The design of Metrics for EG CP shall follow the idea as @Xunzhuo outlined here.

I'll post the initial metrics design here (one by one) before any implementation.

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Apr 30, 2024

@shawnh2 thanks for continuing to implement this, ping me if you need more reviews.

This was referenced May 16, 2024
Closed
Merged
@arkodg arkodg modified the milestones: Backlog, v1.1.0-rc1 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnh2 shawnh2

Labels
area/observability Observability related issues kind/enhancement New feature or request road-to-ga
Projects
No open projects
Envoy Gateway: The Road to GA
Status: Done
Milestone
v1.1.0-rc1
Development

Successfully merging a pull request may close this issue.

feat: add metrics instrumentation for infra manager shawnh2/gateway
3 participants
@arkodg @shawnh2 @Xunzhuo