Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Ordering #2571

Closed
arkodg opened this issue Feb 6, 2024 · 4 comments
Closed

Filter Ordering #2571

arkodg opened this issue Feb 6, 2024 · 4 comments
Labels
area/api API-related issues kind/feature new feature stale
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Feb 6, 2024

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

  • Some users would like to ratelimit request before authenticating them
  • Some would like to first authenticate requests, retrieve claims based on the JWT, and ratelimit based on that

To address such cases, we need to introduce the ability to specify a order of preference in case the default order needs to be overridden (lives in

func newOrderedHTTPFilter(filter *hcmv3.HttpFilter) *OrderedHTTPFilter {
)

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@arkodg arkodg added triage area/api API-related issues kind/feature new feature and removed triage labels Feb 6, 2024
@arkodg arkodg added this to the Backlog milestone Feb 6, 2024
Copy link

github-actions bot commented Mar 8, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Mar 8, 2024
@arkodg arkodg removed the stale label Mar 14, 2024
@zhaohuabing
Copy link
Member

This is blocking EnvoyExtensionPolicy.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@arkodg
Copy link
Contributor Author

arkodg commented May 23, 2024

closing as completed with #3273

@arkodg arkodg closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API-related issues kind/feature new feature stale
Projects
None yet
Development

No branches or pull requests

2 participants