Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egctl x collect #3143

Closed
arkodg opened this issue Apr 9, 2024 · 7 comments
Closed

egctl x collect #3143

arkodg opened this issue Apr 9, 2024 · 7 comments
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Apr 9, 2024

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

  • Collect information from the cluster (e.g. resources in envoy-gateway-system, gateway API resources, EnvoyProxy configdump) to help EG developers diagnose any issues offline
  • Support redaction

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@arkodg arkodg added triage kind/feature new feature help wanted Extra attention is needed and removed triage labels Apr 9, 2024
@arkodg
Copy link
Contributor Author

arkodg commented Apr 9, 2024

relates to #2028

@arkodg arkodg added kind/enhancement New feature or request and removed kind/feature new feature labels Apr 9, 2024
@zirain
Copy link
Contributor

zirain commented Apr 9, 2024

use name of config-dump?

@arkodg
Copy link
Contributor Author

arkodg commented Apr 9, 2024

imo we probably want the o/p to be a tarball rather than just STDOUT text

@arkodg
Copy link
Contributor Author

arkodg commented Apr 11, 2024

adding some existing tools we could reuse

@arkodg arkodg modified the milestones: v1.1.0-rc1, Backlog May 23, 2024
@zirain zirain removed the help wanted Extra attention is needed label Jul 4, 2024
@zirain zirain self-assigned this Jul 4, 2024
@zirain
Copy link
Contributor

zirain commented Jul 4, 2024

I will take a look at this.

@zirain
Copy link
Contributor

zirain commented Jul 8, 2024

troubleshoot didn't match our requirements:

  1. Cluster Resources collector cannot filter custome resources from Gateway API and EG. We can send PRs to improve it but not sure how long it will take, and will upstream accept?
  2. Executing Commands cannot run curl to gather config dump and prometheus metrics cause we're using distroless image; When the selector refers to more than one replica of a pod, the exec collector will execute in only one of the pods.

@zirain
Copy link
Contributor

zirain commented Jul 31, 2024

fixed by #3775

@zirain zirain closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants