New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky: TestE2E/RateLimitCIDRMatch/block_all_ips #3181

Closed

zirain opened this issue Apr 12, 2024 · 2 comments

Labels

Contributor

zirain commented Apr 12, 2024

https://github.com/envoyproxy/gateway/actions/runs/8654873236/job/23733075327

cc @zhaohuabing

zirain added the triage label

Contributor

arkodg commented Apr 12, 2024

I think the issue related to this one, is the default setting for timeout.RequiredConsecutiveSuccesses is 3
https://github.com/kubernetes-sigs/gateway-api/blob/400e36da6929b98674e1d71bdd7eb65ca72e7438/conformance/utils/config/timeout.go#L124

It should be 1, because any more requests sent will count towards the ratelimit

arkodg added help wanted and removed triage labels

Contributor

shawnh2 commented May 17, 2024

seems to be stable now, can reopen if it is flaky again

shawnh2 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment