Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shutdown manager image not possible to override from envoyproxy/gateway-dev #3285

Closed
zetaab opened this issue Apr 26, 2024 · 2 comments
Closed
Labels

Comments

@zetaab
Copy link
Contributor

zetaab commented Apr 26, 2024

Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

I am trying to develop EG and building own gateway controller. However, when I try to start own gateways it will use always envoyproxy/gateway-dev prefix images as shutdown image. It is not possible to override shutdown image as own image. Which makes it really difficult to develop envoy gateway. This shutdown image is defined in

func expectedShutdownManagerImage() string {
if v := version.Get().ShutdownManagerVersion; v != "" {
return fmt.Sprintf("%s:%s", strings.Split(egv1a1.DefaultShutdownManagerImage, ":")[0], v)
}
return egv1a1.DefaultShutdownManagerImage
}
and as you can see, its not possible to override that value.

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

  1. build own envoy gateway controller image GOARCH=amd64 IMAGE=jesseh/envoy-gateway make image
  2. deploy controller with custom image
  3. create new gateway
envoy-eg-internal-7f4ff7e4-5874dd88d9-pprgg   1/2     ImagePullBackOff   0          17m
envoy-eg-internal-7f4ff7e4-7dc49f9c4f-zxhcx   1/2     ImagePullBackOff   0          4m47s
envoy-eg-internal-7f4ff7e4-d9d76b974-p6746    1/2     ImagePullBackOff   0          10m

events:

  Normal   BackOff    3m34s (x6 over 4m56s)  kubelet            Back-off pulling image "envoyproxy/gateway-dev:3f8d05b3"
  Warning  Failed     3m34s (x6 over 4m56s)  kubelet            Error: ImagePullBackOff
  Normal   Pulling    3m22s (x4 over 4m58s)  kubelet            Pulling image "envoyproxy/gateway-dev:3f8d05b3"

in this case the correct image is available in jesseh/gateway-dev:3f8d05b3, but its not possible to override the image in anyway

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Environment:

Include the environment like gateway version, envoy version and so on.

current main branch

Logs:

Include the access logs and the Envoy logs.

@zetaab zetaab added the triage label Apr 26, 2024
@zetaab zetaab changed the title shutdown manager image defaults always envoyproxy/gateway-dev shutdown manager image not possible to override from envoyproxy/gateway-dev Apr 26, 2024
@zetaab
Copy link
Contributor Author

zetaab commented Apr 26, 2024

I manually now modified https://github.com/envoyproxy/gateway/blob/main/api/v1alpha1/shared_types.go#L30 row to jesseh/gateway-dev:latest and everything works fine after new compilation. However, this is not really developer friendly currently

@zetaab
Copy link
Contributor Author

zetaab commented Apr 26, 2024

seems that there is PR #3269 for this already

@zetaab zetaab closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant