Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mergeGateways for egctl #3937

Open
modatwork opened this issue Jul 23, 2024 · 6 comments
Open

Support mergeGateways for egctl #3937

modatwork opened this issue Jul 23, 2024 · 6 comments
Assignees

Comments

@modatwork
Copy link

Description:

egctl x translate --from gateway-api --to xds should set mergeGateways based on GatewayClass's parametersRef.

@shawnh2 shawnh2 added good first issue Good for newcomers help wanted Extra attention is needed area/egctl and removed triage labels Jul 23, 2024
@EraKin575
Copy link

please assign me this. I am interested in working on this issue

@shawnh2 shawnh2 removed the help wanted Extra attention is needed label Jul 23, 2024
@shawnh2
Copy link
Contributor

shawnh2 commented Jul 23, 2024

thanks @EraKin575

@EraKin575
Copy link

@modatwork hi, I am new contributor to this project. Can you please provide some detail about the issue?

@shawnh2
Copy link
Contributor

shawnh2 commented Jul 27, 2024

Sorry for the delay @EraKin575, I think I misunderstood this issue. This issue may not be very friendly for any new contributors. It has some undone prior works, like #3207.

Currently egctl x translate command only parse resources from yaml file but not processing their relationship, so in order to get mergeGateways info, we will need to write up some logic that quite similar as what reconciler does. But that will introduce redundancy compared to current reconciler, so I bring up #3213.

Anyway, thanks pay attention to this issue, feel free to unassign yourself if you find that challenging as well.

@shawnh2 shawnh2 added area/egctl and removed area/egctl good first issue Good for newcomers labels Jul 27, 2024
@EraKin575
Copy link

Thanks @shawnh2 . I will try once if I can solve it

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants