Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPRoute hostname as SNI match for HTTPS traffic #680

Closed
arkodg opened this issue Nov 2, 2022 · 5 comments
Closed

Use HTTPRoute hostname as SNI match for HTTPS traffic #680

arkodg opened this issue Nov 2, 2022 · 5 comments
Assignees
Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. good first issue Good for newcomers help wanted Extra attention is needed priority/low Label used to express the "low" priority level
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Nov 2, 2022

Description:
The current Gateway API Translator logic maps the the Gateway hostname to the Xds IR Listener Hostname and uses the Hostnames within the HTTPRoute spec to populate the Xds IR HeaderMatches
field.

The logic can be optimized to use the intersection between the gateway hostname and http route hostnames, computeHosts to populate the Xds IR Hostnames field

Relates to #662 (comment)

@arkodg arkodg added good first issue Good for newcomers help wanted Extra attention is needed area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. labels Nov 2, 2022
@arkodg arkodg added this to the 0.3.0-rc.1 milestone Nov 2, 2022
@arkodg arkodg added the priority/low Label used to express the "low" priority level label Nov 3, 2022
@shivanshuraj1333
Copy link

I can try to fix this :)
/assign

@danehans
Copy link
Contributor

danehans commented Dec 1, 2022

@shivanshu1333 thanks for your willingness to take on this issue. Are you still planning to fix this issue for the v0.3.0-rc.1 milestone?

@arkodg arkodg modified the milestones: 0.3.0-rc.1, Backlog Jan 12, 2023
@oowl
Copy link
Contributor

oowl commented Jun 15, 2023

Hello, I have seen this issues take a long time and not be fixed, I want to contribute to it. Can I get assigned?

@arkodg
Copy link
Contributor Author

arkodg commented Jun 16, 2023

hey @oowl , thinking out loud, we have a simple mapping of 1:1 today

  • Listener Hostname maps to Server name match within Filter Chain with a xds Listener
  • Route Hostname maps to a :authority header match with the VirtualHost with xds Route Configuration object.

Im unsure if this will actually be a perf improvement or not because we use delta xds to push these resources, which will cause EG to update two resources (Listener and RouteConfiguration) instead of just 1, in the data plane, when the hostname in a HTTPRoute is updated, if we go about making this change.

probably needs more analysis before making the change.

@arkodg
Copy link
Contributor Author

arkodg commented Nov 10, 2023

closed as not needed - we use the listener Hostname for SNI matching and route Hostname in virtual host matching

@arkodg arkodg closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. good first issue Good for newcomers help wanted Extra attention is needed priority/low Label used to express the "low" priority level
Projects
None yet
Development

No branches or pull requests

4 participants