Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stat prefix for xds components #727

Closed
arkodg opened this issue Nov 11, 2022 · 9 comments
Closed

Fix stat prefix for xds components #727

arkodg opened this issue Nov 11, 2022 · 9 comments
Assignees
Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. area/xds-server Issues related to the xDS Server used for managing Envoy configuration. priority/low Label used to express the "low" priority level stale
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Nov 11, 2022

Description:
Add meaningful stat prefixes for xds components such as this

@arkodg arkodg added area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. area/xds-server Issues related to the xDS Server used for managing Envoy configuration. priority/low Label used to express the "low" priority level labels Nov 11, 2022
@arkodg arkodg added this to the Backlog milestone Nov 11, 2022
@arkodg arkodg added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 11, 2022
@shivanshuraj1333
Copy link

/assign

@shivanshuraj1333
Copy link

I'm new to envoy/gateway. I'm unable to understand what exactly we need to do here; some guidance, please...
thanks!!

@arkodg
Copy link
Contributor Author

arkodg commented Nov 12, 2022

hey @shivanshu1333 thanks for volunteering to work on this issue !
the outcome of this issue to fix all the stat_prefix logic within the xds translator which gets assigned to the StatsPrefix field within structures such as the http connection manager and assign sensible string values to it .

@arkodg arkodg removed good first issue Good for newcomers help wanted Extra attention is needed labels Nov 12, 2022
@danehans
Copy link
Contributor

danehans commented Dec 1, 2022

@shivanshu1333 checking if you still plan to work on this issue.

@github-actions github-actions bot added the stale label Dec 31, 2022
@danehans danehans removed the stale label Dec 31, 2022
@envoyproxy envoyproxy deleted a comment from github-actions bot Jan 1, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Jan 31, 2023
@chauhanshubham
Copy link
Member

chauhanshubham commented May 6, 2023

Does it make sense for statPrefix to be the name of the listener?
The metrics would look something like this

http.default-eg-http.rq_total: 0
http.default-eg-http.rs_too_large: 0
http.default-eg-http.tracing.client_enabled: 0
http.default-eg-http.tracing.health_check: 0
http.default-eg-http.tracing.not_traceable: 0
http.default-eg-http.tracing.random_sampling: 0
http.default-eg-http.tracing.service_forced: 0

when done for the quickstart yaml doc

@github-actions github-actions bot removed the stale label May 6, 2023
@arkodg
Copy link
Contributor Author

arkodg commented May 8, 2023

ptal @zirain

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@arkodg
Copy link
Contributor Author

arkodg commented Nov 10, 2023

closing as not needed atm

@arkodg arkodg closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. area/xds-server Issues related to the xDS Server used for managing Envoy configuration. priority/low Label used to express the "low" priority level stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants