From 7a35299354f878b06521bc5f814991991190b767 Mon Sep 17 00:00:00 2001 From: zirain Date: Sat, 16 Mar 2024 20:42:54 +0800 Subject: [PATCH 1/2] chore: make clean should clean tools/bin Signed-off-by: zirain --- tools/make/golang.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/make/golang.mk b/tools/make/golang.mk index 8f30d4a667f..1b8a6b0f29f 100644 --- a/tools/make/golang.mk +++ b/tools/make/golang.mk @@ -106,6 +106,7 @@ format: go.mod.lint .PHONY: clean clean: ## Remove all files that are created during builds. clean: go.clean + rm -rf tools/bin .PHONY: testdata testdata: ## Override the testdata with new configurations. From 5a6cab89789f7605e7e12859e152f4578a225c8c Mon Sep 17 00:00:00 2001 From: zirain Date: Sun, 17 Mar 2024 07:57:31 +0800 Subject: [PATCH 2/2] update Signed-off-by: zirain --- tools/make/golang.mk | 1 - tools/make/tools.mk | 8 ++++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/make/golang.mk b/tools/make/golang.mk index 1b8a6b0f29f..8f30d4a667f 100644 --- a/tools/make/golang.mk +++ b/tools/make/golang.mk @@ -106,7 +106,6 @@ format: go.mod.lint .PHONY: clean clean: ## Remove all files that are created during builds. clean: go.clean - rm -rf tools/bin .PHONY: testdata testdata: ## Override the testdata with new configurations. diff --git a/tools/make/tools.mk b/tools/make/tools.mk index 2edfbcee22a..4943764a972 100644 --- a/tools/make/tools.mk +++ b/tools/make/tools.mk @@ -63,3 +63,11 @@ tools/bin/$(notdir $(SHELLCHECK_TXZ)): mkdir -p $(@D) tar -C $(@D) -Jxmf $< --strip-components=1 shellcheck-v$(SHELLCHECK_VERSION)/shellcheck endif + +tools.clean: # Remove all tools + @$(LOG_TARGET) + rm -rf $(tools.bindir) + +.PHONY: clean +clean: ## Remove all files that are created during builds. +clean: tools.clean