refactor: remove explicit test case definition for xds translator test #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
arkodg
reviewed
Apr 23, 2024
| { | ||
| name: "ratelimit", | ||
| "multiple-listeners-same-port": { | ||
| requireSecrets: true, |
There was a problem hiding this comment.
can this check also be removed, and secrets be asserted if a secrets file exists ?
There was a problem hiding this comment.
by removing requireSecrets and checking secrets from translator result, I found some xxx.secret.yaml were missing, so added in this PR as well
arkodg
reviewed
Apr 23, 2024
| @@ -14,26 +15,6 @@ | |||
| initialStreamWindowSize: 65536 | |||
| maxConcurrentStreams: 100 | |||
| httpFilters: | |||
| - name: envoy.filters.http.jwt_authn | |||
There was a problem hiding this comment.
because this test file has been ignored (not explicit defined in test cases) until now, its content is outdated.
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
zirain
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2229