Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests to use host.testcontainers.internal #303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Feb 28, 2024

  1. Update integration tests to use host.testcontainers.internal

    Motivation
    While I was running the integration test, I found out that `host.docker.internal` doesn't work correctly on Linux. (It worked on Mac and Windows.)
    `host.docker.internal` is used for the container to access the host but the DNS resolution was keeping failing.
    While I was debugging on it, I also found out that the Testcontainers provides `host.testcontainers.internal` for the same purpose and there's no reason not to use it.
    https://java.testcontainers.org/features/networking/
    
    Modification
    - Use `host.testcontainers.internal` instead of `host.docker.internal`
    
    Result
    - The integration tests now run successfully on Linux.
    
    Signed-off-by: minwoox <songmw725@gmail.com>
    minwoox committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    40ddc19 View commit details
    Browse the repository at this point in the history