Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification about parsing-logic #392

Open
mabruzzo opened this issue May 15, 2024 · 0 comments
Open

Clarification about parsing-logic #392

mabruzzo opened this issue May 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mabruzzo
Copy link
Contributor

@jobordner -- I've recently been compiling with Apple's Clang compiler and it raised a noteworthy warning about a codesnippet in the parsing code.

Specifically, it points out that: this line always evaluates to true.

In more detail:

  • the line reads

      if (p->group != NULL) {
  • For context p is a pointer to struct param_struct. In that struct the group member is defined as char * group[MAX_GROUP_DEPTH];.

  • In other words p->member can't be true

It was not immediately obvious to me what's going on here. Should we just remove the else clause here? Or is this a typo (for example instead maybe it should read p->group[0] != NULL)?

@mabruzzo mabruzzo added the bug Something isn't working label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant