You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@jobordner -- I've recently been compiling with Apple's Clang compiler and it raised a noteworthy warning about a codesnippet in the parsing code.
Specifically, it points out that: this line always evaluates to true.
In more detail:
the line reads
if (p->group!=NULL) {
For context p is a pointer to struct param_struct. In that struct the group member is defined as char * group[MAX_GROUP_DEPTH];.
In other words p->member can't be true
It was not immediately obvious to me what's going on here. Should we just remove the else clause here? Or is this a typo (for example instead maybe it should read p->group[0] != NULL)?
The text was updated successfully, but these errors were encountered:
@jobordner -- I've recently been compiling with Apple's Clang compiler and it raised a noteworthy warning about a codesnippet in the parsing code.
Specifically, it points out that: this line always evaluates to true.
In more detail:
the line reads
For context
p
is a pointer to struct param_struct. In that struct thegroup
member is defined aschar * group[MAX_GROUP_DEPTH];
.In other words
p->member
can't be trueIt was not immediately obvious to me what's going on here. Should we just remove the
else
clause here? Or is this a typo (for example instead maybe it should readp->group[0] != NULL
)?The text was updated successfully, but these errors were encountered: