-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-element-to-jsx-string requires react 15 :-( #98
Comments
As a workaround I believe we can loosen up the dependency to do We only have one use case with react-element-to-jsx library so far. |
@ljharb how do you see the most ideal solution? |
That won't solve it, since npm will still try to install the latest. The ideal solution is that nothing is a singleton and nothing needs peer deps :-) but React is a singleton, so all react things must only specify React things as peer deps. In other words, if I want to use chai-enzyme (with react-element-to-jsx-string as a dependency), i must install Another alternative is to simply remove that feature, and drop the dependency. |
bumping to the latest 0.14 seems just fine |
I'm using React 0.14, and react-element-to-jsx-string has a direct dependency (not a peer dep) on react-addons-test-utils - https://npmcdn.com/react-element-to-jsx-string@4.0.0/package.json.
This means that a normal
npm install
will install a 15.x version of react-addons-test-utils, which will then complain that my React 0.14 doesn't work.react-element-to-jsx-string needs to have a peer dep on react-addons-test-utils, not a direct dep.
I'm filing this here, since this is manifesting as a bug in chai-enzyme in that
npm ls
doesn't work when i install it.The text was updated successfully, but these errors were encountered: