refactor: 북마크, Recommendation Converter 리팩토링

eodya · Mar 27, 2024 · e1d8a68 · e1d8a68
1 parent 578c2f7
commit e1d8a68
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 52 deletions.
diff --git a/src/main/java/com/eodya/api/bookmark/domain/BookMark.java b/src/main/java/com/eodya/api/bookmark/domain/BookMark.java
@@ -1,6 +1,6 @@
 package com.eodya.api.bookmark.domain;
 
-import com.eodya.api.bookmark.util.BookMarkStatusAttributeConverter;
+import com.eodya.api.bookmark.util.BookMarkStatusConverter;
 import com.eodya.api.common.entity.BaseEntity;
 import com.eodya.api.place.domain.Place;
 import com.eodya.api.users.domain.User;
@@ -25,7 +25,7 @@ public class BookMark extends BaseEntity {
     private Long id;
 
     @NotNull
-    @Convert(converter = BookMarkStatusAttributeConverter.class)
+    @Convert(converter = BookMarkStatusConverter.class)
     @Column(length = 20)
     private BookMarkStatus status = FALSE;
 

diff --git a/src/main/java/com/eodya/api/bookmark/domain/Bookmark.java b/src/main/java/com/eodya/api/bookmark/domain/Bookmark.java
@@ -1,6 +1,6 @@
 package com.eodya.api.bookmark.domain;
 
-import com.eodya.api.bookmark.util.BookMarkStatusAttributeConverter;
+import com.eodya.api.bookmark.util.BookMarkStatusConverter;
 import com.eodya.api.common.entity.BaseEntity;
 import com.eodya.api.place.domain.Place;
 import com.eodya.api.users.domain.User;
@@ -25,7 +25,7 @@ public class BookMark extends BaseEntity {
     private Long id;
 
     @NotNull
-    @Convert(converter = BookMarkStatusAttributeConverter.class)
+    @Convert(converter = BookMarkStatusConverter.class)
     @Column(length = 20)
     private BookMarkStatus status = FALSE;
 

diff --git a/src/main/java/com/eodya/api/bookmark/util/BookMarkStatusAttributeConverter.java b/src/main/java/com/eodya/api/bookmark/util/BookMarkStatusAttributeConverter.java
diff --git a/src/main/java/com/eodya/api/bookmark/util/BookMarkStatusConverter.java b/src/main/java/com/eodya/api/bookmark/util/BookMarkStatusConverter.java
@@ -1,14 +1,19 @@
 package com.eodya.api.bookmark.util;
 
 import com.eodya.api.bookmark.domain.BookMarkStatus;
-import org.springframework.core.convert.converter.Converter;
-import org.springframework.stereotype.Component;
+import jakarta.persistence.AttributeConverter;
+import jakarta.persistence.Converter;
 
-@Component
-public class BookMarkStatusConverter implements Converter<String, BookMarkStatus> {
+@Converter
+public class BookMarkStatusConverter implements AttributeConverter<BookMarkStatus, String> {
 
     @Override
-    public BookMarkStatus convert(String status) {
+    public String convertToDatabaseColumn(BookMarkStatus bookMarkStatus) {
+        return bookMarkStatus.getDescription();
+    }
+
+    @Override
+    public BookMarkStatus convertToEntityAttribute(String status) {
         return BookMarkStatus.from(status);
     }
 }
diff --git a/src/main/java/com/eodya/api/recommendation/domain/Recommendation.java b/src/main/java/com/eodya/api/recommendation/domain/Recommendation.java
@@ -2,7 +2,7 @@
 
 import com.eodya.api.common.entity.BaseEntity;
 import com.eodya.api.place.domain.Place;
-import com.eodya.api.recommendation.util.RecommendationStatusAttributeConverter;
+import com.eodya.api.recommendation.util.RecommendationStatusConverter;
 import com.eodya.api.users.domain.User;
 import jakarta.persistence.*;
 import jakarta.validation.constraints.NotNull;
@@ -27,7 +27,7 @@ public class Recommendation extends BaseEntity {
     private Long id;
 
     @NotNull
-    @Convert(converter = RecommendationStatusAttributeConverter.class)
+    @Convert(converter = RecommendationStatusConverter.class)
     @Column(length = 20)
     private RecommendationStatus status = FALSE;
 

diff --git a/src/main/java/com/eodya/api/recommendation/util/RecommendationStatusAttributeConverter.java b/src/main/java/com/eodya/api/recommendation/util/RecommendationStatusAttributeConverter.java
diff --git a/src/main/java/com/eodya/api/recommendation/util/RecommendationStatusConverter.java b/src/main/java/com/eodya/api/recommendation/util/RecommendationStatusConverter.java
@@ -1,15 +1,19 @@
 package com.eodya.api.recommendation.util;
 
 import com.eodya.api.recommendation.domain.RecommendationStatus;
-import org.springframework.stereotype.Component;
-import org.springframework.core.convert.converter.Converter;
+import jakarta.persistence.AttributeConverter;
+import jakarta.persistence.Converter;
 
+@Converter
+public class RecommendationStatusConverter implements AttributeConverter<RecommendationStatus, String> {
 
-@Component
-public class RecommendationStatusConverter implements Converter<String, RecommendationStatus> {
+    @Override
+    public String convertToDatabaseColumn(RecommendationStatus recommendationStatus) {
+        return recommendationStatus.getDescription();
+    }
 
     @Override
-    public RecommendationStatus convert(String status) {
+    public RecommendationStatus convertToEntityAttribute(String status) {
         return RecommendationStatus.from(status);
     }
 }