More options for Early stopping criteria #67
Replies: 3 comments 3 replies
-
Seems ok to me. The BLEU/TER scoring codepath might evolve at some point, but that should not conflict with the early stopping logic which only accesses the stats. Thanks for contributing! |
Beta Was this translation helpful? Give feedback.
-
The code logic is super simple, check if TER/BLEU is specified as an argument by user for validation, if so, obtain the values then use it for early stopping. |
Beta Was this translation helpful? Give feedback.
-
tbh the community's consensus is now to use Comet so I think if one needs to use early stopping this is the best criteria IMO. |
Beta Was this translation helpful? Give feedback.
-
I previously created a merge request for using metrics such as BLEU, TER as early stopping metrics. The current metrics perplexity and accuracy might be insufficient, in a lot of scenarios, ppl and acc might be deteriorating but the BLEU and TER metrics are still improving.
After going through the code base, I noticed that the implementation of early stopping is the same. If you guys feel that this could be useful, I could create a new PR and push my code for review.
Beta Was this translation helpful? Give feedback.
All reactions