Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to change the editor font doesn't work. #265

Closed
badsectoracula opened this issue Nov 20, 2024 · 2 comments · Fixed by #267
Closed

Trying to change the editor font doesn't work. #265

badsectoracula opened this issue Nov 20, 2024 · 2 comments · Fixed by #267
Assignees
Labels
bug Something isn't working

Comments

@badsectoracula
Copy link

This is from latest git [3251446] as of this moment. I built seer from source code for Qt6.

Trying to change the editor font doesn't work. Here are the repro steps:

  1. Run some program under seergdb (e.g. i tried it with itself with $ build/seergdb build/seergdb) so you get some source in the editor
  2. Open settings (Settings -> Configuration) and then select the Editor category
  3. Click the "A" button at the top right side of the window to open a popup menu
  4. Select a different font (in my case before pressing the button i had "Source Code Pro" at size 10 and then selected "Adobe Courier" at size 9)
  5. Notice the font preview changing as expected
  6. Press OK to close the dialog
  7. The editor font remains the same as it was previously <--- this is the bug, it should change to Adobe Courier 9
  8. Opening the settings again has the previous font ("Source Code Pro 10" in my PC)

Some extra notes:

  • I am on Linux, Qt6, X11.
  • When opening the font selection dialog (step 3 above) the selected font is actually "Monospace" and not "Source Code Pro" (what the settings dialog shows in the Editor category), though Monospace actually does map to "Source Code Pro" so the latter isn't technically incorrect.
  • It may or may not matter (hopefully not) but "Source Code Pro"'s default font style is "Regular", however this is mapped from "Normal" for "Monospace". "Adobe Courier" also has "Normal".
  • I did try to save the settings and restart the program but didn't make any difference
@epasveer
Copy link
Owner

Thanks for the detailed bug report. It's given me an insight to the problem. It used to work so I must have created a regression sometime recently.

I'll fix it up this weekend.

@epasveer epasveer added the bug Something isn't working label Nov 22, 2024
@epasveer epasveer self-assigned this Nov 22, 2024
@epasveer epasveer linked a pull request Nov 22, 2024 that will close this issue
@epasveer
Copy link
Owner

This has been fixed. A silly mistake on my part.

Checkout the latest code in "main".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants