From bc40d6db80fa86d453eb02dfa44bb2441f5c9049 Mon Sep 17 00:00:00 2001
From: Louis <dev@louis.io>
Date: Tue, 27 Aug 2024 16:01:47 +0200
Subject: [PATCH 1/7] Show removed group conversation messages instead of
 unblock button

Linked to issue #559
---
 .../ChatPlaceholder/GroupChatPlaceholder.tsx  | 52 +++----------------
 1 file changed, 7 insertions(+), 45 deletions(-)

diff --git a/components/Chat/ChatPlaceholder/GroupChatPlaceholder.tsx b/components/Chat/ChatPlaceholder/GroupChatPlaceholder.tsx
index cafec112a..4ad9d9684 100644
--- a/components/Chat/ChatPlaceholder/GroupChatPlaceholder.tsx
+++ b/components/Chat/ChatPlaceholder/GroupChatPlaceholder.tsx
@@ -3,7 +3,7 @@ import { useGroupMembers } from "@hooks/useGroupMembers";
 import { useGroupName } from "@hooks/useGroupName";
 import { translate } from "@i18n";
 import { useGroupQuery } from "@queries/useGroupQuery";
-import { actionSheetColors, textPrimaryColor } from "@styles/colors";
+import { textPrimaryColor } from "@styles/colors";
 import { useCallback, useMemo } from "react";
 import {
   Keyboard,
@@ -20,7 +20,6 @@ import { useConversationContext } from "../../../utils/conversation";
 import { sendMessage } from "../../../utils/message";
 import ActivityIndicator from "../../ActivityIndicator/ActivityIndicator";
 import Button from "../../Button/Button";
-import { showActionSheetWithOptions } from "../../StateHandlers/ActionSheetStateHandler";
 
 type Props = {
   messagesCount: number;
@@ -77,26 +76,6 @@ export function GroupChatPlaceholder({ messagesCount }: Props) {
     }
   }, [conversation, messagesCount, onReadyToFocus]);
 
-  const onUnblock = useCallback(() => {
-    showActionSheetWithOptions(
-      {
-        options: [translate("unblock"), translate("cancel")],
-        cancelButtonIndex: 1,
-        destructiveButtonIndex: isBlockedGroup ? undefined : 0,
-        title: translate("if_you_unblock_group"),
-        ...actionSheetColors(colorScheme),
-      },
-      (selectedIndex?: number) => {
-        if (selectedIndex === 0) {
-          allowGroup({
-            includeCreator: false,
-            includeAddedBy: false,
-          });
-        }
-      }
-    );
-  }, [isBlockedGroup, colorScheme, allowGroup]);
-
   return (
     <TouchableWithoutFeedback onPress={handleDismiss}>
       <View onLayout={onLayout} style={styles.chatPlaceholder}>
@@ -108,38 +87,21 @@ export function GroupChatPlaceholder({ messagesCount }: Props) {
             </Text>
           </View>
         )}
-        {conversation && isBlockedGroup && (
+        {conversation && messagesCount === 0 && !groupCreatedByUser && (
           <View>
             <Text style={styles.chatPlaceholderText}>
-              {translate("this_group_is_blocked")}
+              This is the beginning of your{"\n"}conversation in {groupName}
             </Text>
+
             <Button
               variant="secondary"
-              picto="lock.open"
-              title={translate("unblock")}
+              picto="hand.wave"
+              title={translate("say_hi")}
               style={styles.cta}
-              onPress={onUnblock}
+              onPress={handleSend}
             />
           </View>
         )}
-        {conversation &&
-          !isBlockedGroup &&
-          messagesCount === 0 &&
-          !groupCreatedByUser && (
-            <View>
-              <Text style={styles.chatPlaceholderText}>
-                This is the beginning of your{"\n"}conversation in {groupName}
-              </Text>
-
-              <Button
-                variant="secondary"
-                picto="hand.wave"
-                title={translate("say_hi")}
-                style={styles.cta}
-                onPress={handleSend}
-              />
-            </View>
-          )}
       </View>
     </TouchableWithoutFeedback>
   );

From 7e3ef6b61974f949e553f7468f69b97c356b304e Mon Sep 17 00:00:00 2001
From: Louis <dev@louis.io>
Date: Tue, 27 Aug 2024 16:04:10 +0200
Subject: [PATCH 2/7] Translation housekeeping

---
 i18n/translations/en.ts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/i18n/translations/en.ts b/i18n/translations/en.ts
index 5b656087e..4adecc388 100644
--- a/i18n/translations/en.ts
+++ b/i18n/translations/en.ts
@@ -24,7 +24,6 @@ const en = {
   block: "Block",
   decline: "Decline",
   unblock: "Unblock",
-  this_group_is_blocked: "This group is blocked",
   if_you_unblock_contact:
     "If you unblock this contact, they will be able to send you messages again.",
   if_you_block_contact:

From a78e106a66a23f53108ab75c735f731d0a02b981 Mon Sep 17 00:00:00 2001
From: Louis <dev@louis.io>
Date: Tue, 27 Aug 2024 16:09:32 +0200
Subject: [PATCH 3/7] Fix a bug where consent window was shown for the user who
 create the group chat

This is because `groupStatus` expects a `groupId` key instead of a `conversation.topic`
---
 components/Chat/ConsentPopup/GroupConsentPopup.tsx | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/components/Chat/ConsentPopup/GroupConsentPopup.tsx b/components/Chat/ConsentPopup/GroupConsentPopup.tsx
index 95f65ffe5..97316518a 100644
--- a/components/Chat/ConsentPopup/GroupConsentPopup.tsx
+++ b/components/Chat/ConsentPopup/GroupConsentPopup.tsx
@@ -10,6 +10,7 @@ import {
   backgroundColor,
   textPrimaryColor,
 } from "@styles/colors";
+import { getGroupIdFromTopic } from "@utils/groupUtils/groupId";
 import React, { useCallback, useMemo } from "react";
 import { StyleSheet, Text, useColorScheme, View } from "react-native";
 
@@ -42,7 +43,8 @@ export function GroupConsentPopup() {
   const { groupCreator } = useGroupCreator(topic);
   const { groupStatus } = useSettingsStore(useSelect(["groupStatus"]));
   const { members } = useGroupMembers(topic);
-  const groupStatusForTopic = groupStatus[topic];
+  const groupId = getGroupIdFromTopic(topic);
+  const groupStatusForTopic = groupStatus[groupId];
 
   const isCreator = useMemo(() => {
     if (!members || !currentAccount) {

From d8ac33705db01d4e87bafc347f0b1d0dc0b129cb Mon Sep 17 00:00:00 2001
From: Louis <dev@louis.io>
Date: Tue, 27 Aug 2024 17:37:08 +0200
Subject: [PATCH 4/7] Show action sheet before entering a restored conversation
 #315

---
 components/ConversationListItem.tsx | 63 ++++++++++++++++++++++++++++-
 i18n/translations/en.ts             |  3 ++
 2 files changed, 64 insertions(+), 2 deletions(-)

diff --git a/components/ConversationListItem.tsx b/components/ConversationListItem.tsx
index b75c5e79c..3d1fdddaf 100644
--- a/components/ConversationListItem.tsx
+++ b/components/ConversationListItem.tsx
@@ -1,3 +1,4 @@
+import { useGroupConsent } from "@hooks/useGroupConsent";
 import { translate } from "@i18n";
 import { NativeStackScreenProps } from "@react-navigation/native-stack";
 import {
@@ -109,8 +110,57 @@ const ConversationListItem = memo(function ConversationListItem({
   const hasImagePreview = lastMessageImageUrl && lastMessagePreview;
   const showError = lastMessageFromMe && lastMessageStatus === "error";
   const isBlockedChatView = route.name === "Blocked";
+  const { allowGroup } = useGroupConsent(conversationTopic);
 
   const openConversation = useCallback(async () => {
+    const getUserAction = async () => {
+      const methods = {
+        [translate("view_only")]: () => {},
+        [translate("view_and_restore")]: () => {
+          allowGroup({
+            includeCreator: false,
+            includeAddedBy: false,
+          });
+        },
+        [translate("cancel")]: () => {
+          return null;
+        },
+      };
+      const options = Object.keys(methods);
+
+      return new Promise<(() => void) | null>((resolve) => {
+        showActionSheetWithOptions(
+          {
+            options,
+            title: translate("view_removed_group_chat"),
+            cancelButtonIndex: 2,
+            ...actionSheetColors(colorScheme),
+          },
+          (selectedIndex?: number) => {
+            if (
+              selectedIndex === undefined ||
+              options[selectedIndex] === translate("cancel")
+            ) {
+              return resolve(null);
+            }
+            const method = (methods as any)[options[selectedIndex]];
+            resolve(method);
+          }
+        );
+      });
+    };
+
+    // Ask user's approval when visiting blocked group chats
+    if (isGroupConversation && isBlockedChatView) {
+      const userAction = await getUserAction();
+      if (userAction === null) {
+        setSelected(false);
+        return; // User canceled, stop further execution
+      }
+      userAction();
+    }
+
+    // Open conversation
     if (route.params?.frameURL) {
       // Sharing a frame !!
       navigation.goBack();
@@ -134,14 +184,23 @@ const ConversationListItem = memo(function ConversationListItem({
       topic: conversationTopic,
       message: route.params?.frameURL,
     });
-  }, [conversationTopic, isSplitScreen, navigation, route.params?.frameURL]);
+  }, [
+    conversationTopic,
+    isSplitScreen,
+    navigation,
+    route.params?.frameURL,
+    colorScheme,
+    isGroupConversation,
+    isBlockedChatView,
+    allowGroup,
+  ]);
 
   useEffect(() => {
     navigation.addListener("transitionEnd", resetSelected);
     return () => {
       navigation.removeListener("transitionEnd", resetSelected);
     };
-  }, [navigation, resetSelected]);
+  }, [navigation, resetSelected, isGroupConversation]);
 
   const avatarComponent = useMemo(() => {
     return isGroupConversation ? (
diff --git a/i18n/translations/en.ts b/i18n/translations/en.ts
index 4adecc388..cec869a26 100644
--- a/i18n/translations/en.ts
+++ b/i18n/translations/en.ts
@@ -18,6 +18,9 @@ const en = {
   restore_and_unblock_inviter: "Restore and unblock inviter",
   unblock_and_restore: "Unblock and restore",
   cancel: "Cancel",
+  view_only: "View only",
+  view_and_restore: "View and Restore",
+  view_removed_group_chat: "View removed group chat?",
 
   // Conversation
   accept: "Accept",

From 8457105d6a1ff7e169aebae8d413abf0fd34fdf6 Mon Sep 17 00:00:00 2001
From: Louis <dev@louis.io>
Date: Tue, 27 Aug 2024 18:01:40 +0200
Subject: [PATCH 5/7] Take the user back to wherever the conversation was
 restored "to"

Linked to #315
---
 components/ConversationListItem.tsx | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/components/ConversationListItem.tsx b/components/ConversationListItem.tsx
index 3d1fdddaf..faa090f5d 100644
--- a/components/ConversationListItem.tsx
+++ b/components/ConversationListItem.tsx
@@ -121,10 +121,11 @@ const ConversationListItem = memo(function ConversationListItem({
             includeCreator: false,
             includeAddedBy: false,
           });
+          // Take the user back to wherever the conversation was restored "to"
+          // https://github.com/ephemeraHQ/converse-app/issues/315#issuecomment-2312903441
+          navigation.pop(2);
         },
-        [translate("cancel")]: () => {
-          return null;
-        },
+        [translate("cancel")]: () => {},
       };
       const options = Object.keys(methods);
 

From b91b890a1de830c820d38cb19e21979668c54074 Mon Sep 17 00:00:00 2001
From: Louis <dev@louis.io>
Date: Tue, 27 Aug 2024 18:05:32 +0200
Subject: [PATCH 6/7] Fix navigation pop for split screens

Linked to #315
---
 components/ConversationListItem.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/ConversationListItem.tsx b/components/ConversationListItem.tsx
index faa090f5d..63e7e5ceb 100644
--- a/components/ConversationListItem.tsx
+++ b/components/ConversationListItem.tsx
@@ -123,7 +123,7 @@ const ConversationListItem = memo(function ConversationListItem({
           });
           // Take the user back to wherever the conversation was restored "to"
           // https://github.com/ephemeraHQ/converse-app/issues/315#issuecomment-2312903441
-          navigation.pop(2);
+          navigation.pop(isSplitScreen ? 1 : 2);
         },
         [translate("cancel")]: () => {},
       };

From 1030ffa4310123fdbf42ffda6dc7628977cc9129 Mon Sep 17 00:00:00 2001
From: Louis <dev@louis.io>
Date: Tue, 27 Aug 2024 18:25:31 +0200
Subject: [PATCH 7/7] Remove unused hook dependency

---
 components/ConversationListItem.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/ConversationListItem.tsx b/components/ConversationListItem.tsx
index 63e7e5ceb..bd39766ba 100644
--- a/components/ConversationListItem.tsx
+++ b/components/ConversationListItem.tsx
@@ -201,7 +201,7 @@ const ConversationListItem = memo(function ConversationListItem({
     return () => {
       navigation.removeListener("transitionEnd", resetSelected);
     };
-  }, [navigation, resetSelected, isGroupConversation]);
+  }, [navigation, resetSelected]);
 
   const avatarComponent = useMemo(() => {
     return isGroupConversation ? (