Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also show responsible groups in the "visible for" list #1258

Open
lukasrad02 opened this issue Apr 4, 2024 · 1 comment · May be fixed by #1452
Open

Also show responsible groups in the "visible for" list #1258

lukasrad02 opened this issue Apr 4, 2024 · 1 comment · May be fixed by #1452
Labels
[C] design/ui Enhancement of existing views easy Good for newcomers [P] minor features or bugs that can wait for some more time

Comments

@lukasrad02
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When creating an event that should be visible by groups A and B and where group A is responsible/can manage the event, group A won't be shown in the "visible for" list after saving the event. This makes sense, as managing an event should always include viewing it, but it might be confusing when groups that have been added to the "visible for" list disappear from it after saving.

Describe the solution you'd like

I'm not sure about a perfect solution, as the other way round (also showing managing groups in the "visible for" list) could also be confusing: If a group is removed from that list, but still among the managers, it will keep its view permissions, although it has been removed. Some solutions that might make sense, maybe also in combination:

  • Below the "visible for" box, there is some help text saying

    [...] Unabhängig davon ist die Veranstaltung für alle Benutzer sichtbar, die sich bereits angemeldet haben.

    It would make sense to add

    [...] und alle Gruppen, die für die Veranstaltung verantwortlich sind

  • When a group is added to both lists during editing, show a information sign on the group with a tooltip specifying that the group will receive the view permission automatically.

  • Instead of the two separate selects, show a table of all groups with radio buttons for permissions. If a table of all groups would be to long, show an empty table with a select to add groups

Describe alternatives you've considered

see above

Additional context

none

@lukasrad02
Copy link
Contributor Author

I've just noticed that this issue is just the opposite of #148, where you explicitly removed the responsible groups from the "visible for" list. Nevertheless, I'd suggest to at least update the help text.

@jeriox jeriox added easy Good for newcomers [P] minor features or bugs that can wait for some more time [C] design/ui Enhancement of existing views labels Sep 11, 2024
@jeriox jeriox linked a pull request Dec 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] design/ui Enhancement of existing views easy Good for newcomers [P] minor features or bugs that can wait for some more time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants