From 3f4d02e038add5c95ffddb75e9e44dbcdfd6596c Mon Sep 17 00:00:00 2001
From: patrickbarks <patrick.barks@gmail.com>
Date: Thu, 22 Feb 2024 16:50:37 +0100
Subject: [PATCH] rm warning supression, and convert all cols to chr before
 reclassing

---
 R/reclass_data.R | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/R/reclass_data.R b/R/reclass_data.R
index b80ce90..9f61d60 100644
--- a/R/reclass_data.R
+++ b/R/reclass_data.R
@@ -13,7 +13,7 @@
 #' @return
 #' The dataset with columns reclassed to match the data dictionary
 #'
-#' @importFrom dplyr `%>%`
+#' @importFrom dplyr `%>%` mutate across everything
 #' @export reclass_data
 reclass_data <- function(data,
                          dict,
@@ -24,6 +24,7 @@ reclass_data <- function(data,
   check_dict <- valid_dict(dict)
 
   data %>%
+    mutate(across(everything(), as.character)) %>%
     reclass(dict, "Numeric", format_date, format_time, format_datetime) %>%
     reclass(dict, "Date", format_date, format_time, format_datetime) %>%
     reclass(dict, "Time", format_date, format_time, format_datetime) %>%
@@ -50,9 +51,9 @@ reclass <- function(data, dict, type, format_date, format_time, format_datetime)
   out <- data
 
   for (var in vars_focal) {
-    data[[var]] <- suppressWarnings(fn_class(data[[var]]))
+    out[[var]] <- fn_class(out[[var]])
   }
 
-  return(data)
+  return(out)
 }