redirect to external site in root.tsx loader doesn't work, still calls App

[cjkooij]

Trying to return a redirect from the root.tsx loader doesn't redirect and tries to render the App.

See screenshots below, redirect is the only line added on a freshly installed epic-stack.

[cjkooij]

throwing redirect does work, credit to @jacobparis

[kentcdodds]

I'm curious why returning a redirect doesn't work though. Perhaps this is a bug for Remix?

[cjkooij]

Weirdly enough if I do this in a plain stack it seems to work.

…

On 3 Jul 2023, at 20:35, Kent C. Dodds ***@***.***> wrote: I'm curious why returning a redirect doesn't work though. Perhaps this is a bug for Remix? — Reply to this email directly, view it on GitHub <#256 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARHVEM46QONFGWP6A5IB3QLXOL7FVANCNFSM6AAAAAAZ4N5NBM>. You are receiving this because you authored the thread.

[kentcdodds]

Thanks for checking on that! We'll definitely want to figure out what it is then.

[onemen]

maybe the bug is in server/index.js

when i replace server/index.js file with the content of remix express/server

with just one change

-  const BUILD_PATH = './build/index.js'
+  const BUILD_PATH = '../build/index.js'

the redirect work as expected

[onemen]

something wrong with sentry wrapExpressCreateRequestHandler, when removed from server/index.js redirect work as expected

import path from 'path'
import { fileURLToPath } from 'url'
import express from 'express'
import chokidar from 'chokidar'
import compression from 'compression'
import morgan from 'morgan'
import address from 'address'
import closeWithGrace from 'close-with-grace'
import helmet from 'helmet'
import crypto from 'crypto'
-import {
-  type RequestHandler,
-  createRequestHandler as _createRequestHandler,
-} from '@remix-run/express'
+import { type RequestHandler, createRequestHandler } from '@remix-run/express'
import { wrapExpressCreateRequestHandler } from '@sentry/remix'
import { type ServerBuild, broadcastDevReady } from '@remix-run/node'
import getPort, { portNumbers } from 'get-port'
import chalk from 'chalk'

// @ts-ignore - this file may not exist if you haven't built yet, but it will
// definitely exist by the time the dev or prod server actually runs.
import * as remixBuild from '../build/index.js'
const MODE = process.env.NODE_ENV

-const createRequestHandler = wrapExpressCreateRequestHandler(
-  _createRequestHandler,
-)

const BUILD_PATH = '../build/index.js'

[kentcdodds]

Hey @scefali, do you have any idea what may be causing this issue? Looks like it's only present when Sentry's wrapper is involved.

[scefali]

@kentcdodds I do not but I'm having someone take a look

[AbhiPrasad]

@onurtemizkan something lets take a look at?

This might be fixed by us merging and releasing getsentry/sentry-javascript#8415

Sorry for the trouble folks!

[AbhiPrasad]

Also if you could run npm why @sentry/remix and report the version would help us debug a lot!

[AbhiPrasad]

We'll try and get a fix out friday or start of next week, thanks for your patience everyone.

[AbhiPrasad]

We've released a new version of @sentry/remix with the fix in 7.58.0. Can you try updating your SDK version and seeing if the error persists? Thanks!

[kentcdodds]

Thanks a lot!