Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entities should have only members, not @property #85

Open
epignatelli opened this issue Jul 8, 2024 · 0 comments
Open

Entities should have only members, not @property #85

epignatelli opened this issue Jul 8, 2024 · 0 comments

Comments

@epignatelli
Copy link
Owner

For clarity and to minimise entropy, entities should not implement @property, but full members.

For example:

class Foo(Entity):
  walkable: Array = jnp.asarray(False)

While this can be problematic for broadcasting, when entities are batched, the create method should take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: TODOs
Development

No branches or pull requests

1 participant