Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace internal function by exported function in error messages #76

Open
Bisaloo opened this issue Feb 19, 2024 · 0 comments
Open

Replace internal function by exported function in error messages #76

Bisaloo opened this issue Feb 19, 2024 · 0 comments

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Feb 19, 2024

stop("Provided attribute ids not found!\n
Use readepi:::dhis2_make_api_request() function to view the list of
available attributes")

This error message recommends using an internal function via :::, which is not something we should encourage. It is bad practice in R in general, and it mean that function is now effectively part of our public interface if we want to do changes.

Either this function can be called by users and it should be exported, and it shouldn't be called by users and we should propose an alternative in the error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant