-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass argument from fit_seromodel()
to rstan::sampling()
via ...
#118
Comments
Partially, I would also encourage you to simplify the fit_seromodel <- function(
serodata,
foi_model = c("constant", "tv_normal_log", "tv_normal"),
...
) { However, here are two reasons you may have to keep some argument explicit rather than folding them into
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, it seems that several arguments are passed from
fit_seromodel()
torstan::sampling()
directly, without any transformation.Additionally, some
rstan::sampling()
are hardcoded, even though users might want to adjust them (e.g., number of chains).The standard way to deal with this, allowing for maximum flexibility while keeping the
fit_seromodel()
function signature concise and clear, would be to pass argument torstan::sampling()
via...
.Additional reading on
...
: https://adv-r.hadley.nz/functions.html#fun-dot-dot-dotThe text was updated successfully, but these errors were encountered: