Adding https support on OpenShift #115
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
reviewed
Oct 9, 2024
|
|
||
| # -- (object) The readinessProbe to use for the krakend pod | ||
| readinessProbe: | ||
| httpGet: | ||
| path: /__health | ||
| port: http | ||
| scheme: HTTPS |
There was a problem hiding this comment.
We might need to use a macro for this instead of setting it up directly here. HTTPS won't work in default settings where TLS is not handled by krakend.
There was a problem hiding this comment.
Note this is still a blocker for merging this.
There was a problem hiding this comment.
Sorry, I thought I created the pull request in DRAFT mode, I wasn't done yet and I'm aware that there are some things that are not yet general enough but just take care of my own issue. I will try and generalize and address your comments
JAORMX
reviewed
Oct 18, 2024
| @@ -6,5 +6,5 @@ description: |- | |||
| and maintained by your friends at Equinix Metal | |||
|
|
|||
| type: application | |||
| version: 0.1.35 | |||
| version: 0.1.35-os-2 | |||
|
|
||
| # -- (object) The readinessProbe to use for the krakend pod | ||
| readinessProbe: | ||
| httpGet: | ||
| path: /__health | ||
| port: http | ||
| scheme: HTTPS |
There was a problem hiding this comment.
Note this is still a blocker for merging this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.