Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 [punch]: Enable 3D in sidesheet #582

Closed
Tracked by #578
Noggling opened this issue Sep 20, 2023 · 4 comments · Fixed by #951
Closed
Tracked by #578

🎁 [punch]: Enable 3D in sidesheet #582

Noggling opened this issue Sep 20, 2023 · 4 comments · Fixed by #951
Assignees
Labels
question Further information is requested

Comments

@Noggling
Copy link
Contributor

Noggling commented Sep 20, 2023

The baseline 3D Model-viewer component is finished, and available for use in all cc-applications.
Implemented in PR #774

To use it in the rest of the applications, the following needs to be done:

  1. Create a new endpoint in each of the apps returning the relevant tags for a given entity. (/echo endpoint, see work-order implementation)
  2. Enable the model-viewer in application config.
  3. Add the ModelViewerTab to each sidesheet with relevant props.

In order to implement this, PO must provide a list of which types of tags that are relevant for 3D for each application.

@kjellhaaland
Copy link
Contributor

@jone, which tags are relevant for 3D for this application?

@atlewee
Copy link

atlewee commented Apr 11, 2024

@kjellhaaland Punch is attached to a checklist/mccr.. and that checklist is for one single tag.
( So for punch it will always be 1 tag, never 0 and never more than one )

@kjellhaaland kjellhaaland linked a pull request Apr 15, 2024 that will close this issue
3 tasks
@kjellhaaland
Copy link
Contributor

@JoneUE, ModelViewer for Punch is now ready for test.

Link to test: https://webserver-fusion-project-portal-test.radix.equinor.com/apps/punch

Can you test and verify that its ok?

@JoneUE
Copy link
Contributor

JoneUE commented Apr 15, 2024

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants