-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎁: Handover: Highlight non-counting scope #613
Comments
UX should have a say in how this visually could be displayed. @chriispychiicken @atlewee you have not specified portal - but I vaguely remember you indicated JC Portal. Also, consider the delivered value vs cost and what the implication is if this is not implemented. |
@chriispychiicken Probably a lot simpler view that way (Only one commPk, not the full dataset) @ken-mellem |
I can talk to Lotte about it and see if we can come up with a good solution :) It Is a bit tricky, as adding even more to an already overpacked component will make everything look chaotic, so we have to find a good way to add it. |
@BenSvend could you assist here with the calculation? |
Yes @ken-mellem, but I am not sure what view i need to do the calculations in? @atlewee do you know which view it is? |
@atlewee is it important for the user to see that the status is not 100% ok in the garden view or is it most important to be able to see it in the sidesheet? |
@chriispychiicken McStatus in sidesheet is good enough.. Maybe a warning somewhere here with a tooltip on the warning with an explanation: @BenSvend |
@chriispychiicken Har noen brukere som etterspør status på denne. Fikk dere kjangs å se på noe design? |
Wokring on it now, Ill put in some pictures of deisgn ila dagen :) |
I think that will work yes :) |
@chriispychiicken so - if you have an approved UX design, we should work on the flow here - @espenkalle is finalizing the Handover app - this will be a first new good enhancement we should aim to add as the app is to be made available on JC-Portal. |
WorstChecklistStatus has been added to FAM DEV @espenkalle. You should be able to preform the calculation once FAM has added the changes to PROD. |
Updated state to Ready for Test @espenkalle - please set appropriate state |
Expected outcome
User can easily see CommPks that are not fully complete. (has non-counting scope)
Business Value / Developer Experience
In ProCoSys the administrator can mark Form.Responsible codes counting or non-counting.
eksample: responsible code "KSI" is currently Counting but "KSIC" is not.
(This information is currently not possible to extract from ProCoSys, and is not sent to FAM)
All MC packages and CommPackages has a field called "mcStatus" calculated from the worst status of checklists in that package.
The counting/non-counting flag determines what checklists contributes to the aggregated status.
This means that some commPks might have mcStatus: OK, but it actually contains non-counting checklists with status OS.
In the Garden view the mcStatus is currently shown as the first "dot" on the right side:
Tooltip explaining this:
We should find a way to hightlight if the package is green but the dot is not 100% correct. Something like this:
Or a star / caviat symbol?
Possible solution
To find out if the warning should be shown, the FAM view could add a new field called "worstChecklistStatus" calculated from checklists connected to the commPk.
If worstChecklistStatus is worse than Commpk.McStatus we show the warning for non-counting scope.
( Status from worst to best: OS,PA,PB,OK )
Acceptance Criteria
https://procosys.equinor.com/JOHAN_CASTBERG/Search/Load?searchId=120462
The text was updated successfully, but these errors were encountered: