Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁: Handover: Highlight non-counting scope #613

Closed
2 tasks
atlewee opened this issue Oct 3, 2023 · 14 comments · Fixed by #687
Closed
2 tasks

🎁: Handover: Highlight non-counting scope #613

atlewee opened this issue Oct 3, 2023 · 14 comments · Fixed by #687
Assignees
Labels
enhancement New feature or request

Comments

@atlewee
Copy link

atlewee commented Oct 3, 2023

Expected outcome

User can easily see CommPks that are not fully complete. (has non-counting scope)

Business Value / Developer Experience

In ProCoSys the administrator can mark Form.Responsible codes counting or non-counting.
eksample: responsible code "KSI" is currently Counting but "KSIC" is not.
image
image
(This information is currently not possible to extract from ProCoSys, and is not sent to FAM)

All MC packages and CommPackages has a field called "mcStatus" calculated from the worst status of checklists in that package.
The counting/non-counting flag determines what checklists contributes to the aggregated status.

This means that some commPks might have mcStatus: OK, but it actually contains non-counting checklists with status OS.

In the Garden view the mcStatus is currently shown as the first "dot" on the right side:
image
Tooltip explaining this:
image

We should find a way to hightlight if the package is green but the dot is not 100% correct. Something like this:
image
Or a star / caviat symbol?

Possible solution

To find out if the warning should be shown, the FAM view could add a new field called "worstChecklistStatus" calculated from checklists connected to the commPk.
If worstChecklistStatus is worse than Commpk.McStatus we show the warning for non-counting scope.
( Status from worst to best: OS,PA,PB,OK )

Acceptance Criteria

  • It is possible to see if there is outstanding non-counting scope hidden behind a good mcStatus
  • Spot check that commPks from the following search has the new warning:

image
https://procosys.equinor.com/JOHAN_CASTBERG/Search/Load?searchId=120462

@atlewee atlewee added the feature label Oct 3, 2023
@ken-mellem ken-mellem added the enhancement New feature or request label Oct 3, 2023
@ken-mellem
Copy link
Contributor

UX should have a say in how this visually could be displayed. @chriispychiicken
@aman-riaz @BenSvend could you assess if this is fairly straight forward to implement in the view in question?

@atlewee you have not specified portal - but I vaguely remember you indicated JC Portal. Also, consider the delivered value vs cost and what the implication is if this is not implemented.

@ken-mellem ken-mellem self-assigned this Oct 5, 2023
@atlewee
Copy link
Author

atlewee commented Oct 5, 2023

@chriispychiicken
It does not have to be visualised in the garden itself that was just an example, maybe a warning in the sidesheet is a better solution.?.

Probably a lot simpler view that way (Only one commPk, not the full dataset)

@ken-mellem
The request is coming from Castberg. And there is more tweeks coming that we should have both places.
I think we should consider upgrading to the scaled versions of CC apps in JC portal so that we only need to maintain one set.

@chriispychiicken
Copy link

I can talk to Lotte about it and see if we can come up with a good solution :) It Is a bit tricky, as adding even more to an already overpacked component will make everything look chaotic, so we have to find a good way to add it.

@ken-mellem
Copy link
Contributor

@BenSvend could you assist here with the calculation?

@BenSvend
Copy link
Contributor

Yes @ken-mellem, but I am not sure what view i need to do the calculations in? @atlewee do you know which view it is?

@chriispychiicken
Copy link

@atlewee is it important for the user to see that the status is not 100% ok in the garden view or is it most important to be able to see it in the sidesheet?

@atlewee
Copy link
Author

atlewee commented Oct 12, 2023

@chriispychiicken McStatus in sidesheet is good enough.. Maybe a warning somewhere here with a tooltip on the warning with an explanation:
image

@BenSvend
Tror det blir cc-backend på ProjectPortal:
https://backend-fusion-data-gateway-prod.radix.equinor.com/api/contexts/{context}/handover/{commpk}
JC:
https://fusion-s-dataproxy-fprd.azurewebsites.net/api/contexts/{context}/handover/{commpk}/details

@atlewee
Copy link
Author

atlewee commented Oct 17, 2023

@chriispychiicken Har noen brukere som etterspør status på denne. Fikk dere kjangs å se på noe design?

@chriispychiicken
Copy link

@chriispychiicken Har noen brukere som etterspør status på denne. Fikk dere kjangs å se på noe design?

Wokring on it now, Ill put in some pictures of deisgn ila dagen :)

@chriispychiicken
Copy link

bilde
noe sånt?

@atlewee
Copy link
Author

atlewee commented Oct 19, 2023

I think that will work yes :)

@ken-mellem
Copy link
Contributor

@chriispychiicken so - if you have an approved UX design, we should work on the flow here - @espenkalle is finalizing the Handover app - this will be a first new good enhancement we should aim to add as the app is to be made available on JC-Portal.

@ken-mellem ken-mellem assigned espenkalle and unassigned ken-mellem Nov 12, 2023
@espenkalle espenkalle assigned ken-mellem and BenSvend and unassigned ken-mellem Nov 15, 2023
@espenkalle espenkalle linked a pull request Nov 15, 2023 that will close this issue
@BenSvend
Copy link
Contributor

BenSvend commented Dec 1, 2023

WorstChecklistStatus has been added to FAM DEV @espenkalle. You should be able to preform the calculation once FAM has added the changes to PROD.

@ken-mellem
Copy link
Contributor

Updated state to Ready for Test @espenkalle - please set appropriate state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants