Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁: Heat trace - Table - Need more columns #856

Closed
MagnusGjosund opened this issue Feb 9, 2024 · 4 comments
Closed

🎁: Heat trace - Table - Need more columns #856

MagnusGjosund opened this issue Feb 9, 2024 · 4 comments
Assignees
Labels

Comments

@MagnusGjosund
Copy link
Contributor

MagnusGjosund commented Feb 9, 2024

Expected outcome

Need more columns in table. Look at pipings miro board ( https://miro.com/app/board/uXjVNM_KarU=/ )

New columns:

  • MC Handover Status
  • Comm Priority 2
  • Comm Priority 3
  • Comm Identifier
  • MC responsible
  • MC Phase

@aman-riaz i think Custom_HeatTraceV2 is missing data for "MC Handover Status", "Comm Identifier" and "MC phase". Are you able to add these?

Business Value / Developer Experience

Better ux

Acceptance Criteria

See that the correct columns is added

@MagnusGjosund MagnusGjosund self-assigned this Feb 12, 2024
@MagnusGjosund
Copy link
Contributor Author

Added Comm Priority 2, Comm Priority 3 and MC responsible. Missing data on MC Handover Status, Comm Identifier and MC Phase. Aman gonna add these fields.

PR: #864

@aman-riaz
Copy link
Contributor

aman-riaz commented Feb 12, 2024

Added following fields to Custom_HeatTrace_V2:

  • MechanicalCompletionPhase
  • MechanicalCompletionHandoverStatus
  • CommissioningIdentifierCode
  • CommissioningIdentifierDescription (This is the full description of the Identifier Code)

The execution time of the view has increased with around 15-20 seconds due to addition of more joins and data. Not sure if this will be noticable in the app or not. @MagnusGjosund Please let me know if you experience slower data fetch.

Available in FAM API by tues/wednesday.

@aman-riaz aman-riaz self-assigned this Feb 12, 2024
@MagnusGjosund
Copy link
Contributor Author

Put on-hold. More important bugs/issues on RC right now

@MagnusGjosund
Copy link
Contributor Author

PR Backend: https://github.com/equinor/fusion-data-gateway/pull/508
PR Frontend: #864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants