Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement outside click for garden popover #424

Closed
Gustav-Eikaas opened this issue Jun 13, 2023 · 4 comments
Closed

Implement outside click for garden popover #424

Gustav-Eikaas opened this issue Jun 13, 2023 · 4 comments
Assignees
@MagnusGjosund
Labels
bug Something isn't working on-hold

Comments

@Gustav-Eikaas
Copy link
Contributor

Gustav-Eikaas commented Jun 13, 2023 •
edited
Loading

image
Doesnt close unless pressing the x button

Expected behaviour: The popover should close when clicking outside the popover
@Gustav-Eikaas
Copy link
Contributor Author

You could probably fix this aswell @MagnusGjosund. Im pretty sure EDS have a useOutsideClick. Otherwise look through lighthouse-client

@MagnusGjosund MagnusGjosund linked a pull request Jul 6, 2023 that will close this issue
feat: ✨ add outsideclick #442
Closed
4 tasks
@MagnusGjosund
Copy link
Contributor

This was a complicated task, then i got a lot of mergeconflicts i had a hard time to resolve. Need a break from this task. We should mabye just create a new branch and start all over. I didn't write a lot of code. The hard work was some technical things and some logic

@MagnusGjosund MagnusGjosund added the bug Something isn't working label Aug 18, 2023
@MagnusGjosund MagnusGjosund mentioned this issue Aug 18, 2023
Closed
@MagnusGjosund
Copy link
Contributor

Made a new issue to start all over again #457

@MagnusGjosund
Copy link
Contributor

Solved in this pr #458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MagnusGjosund MagnusGjosund

Labels
bug Something isn't working on-hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ✨ add outsideclick equinor/fusion-workspace
2 participants
@MagnusGjosund @Gustav-Eikaas