Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛: PBI workspace: Name change on filters error #601

Open
JoneUE opened this issue Apr 4, 2024 · 1 comment
Open

🐛: PBI workspace: Name change on filters error #601

JoneUE opened this issue Apr 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@JoneUE
Copy link

JoneUE commented Apr 4, 2024

Description

When changing name on a filter in PBI, the old filter names are selected, but the new ones are not. See picture

Image
@JoneUE JoneUE added the bug Something isn't working label Apr 4, 2024
@Gustav-Eikaas Gustav-Eikaas removed their assignment May 14, 2024
@Gustav-Eikaas
Copy link
Contributor

Gustav-Eikaas commented May 14, 2024 •
edited
Loading

Dev context

Changes was introduced in #525
PR: #525
Issue: #526
Relevant line: https://github.com/equinor/fusion-workspace/pull/525/files#diff-9d19589d9578f638067fcc6520c231174f4ca74d2b701cbffc41fdca9662f0e3R5-R13

Seems once again to be an issue with powerbi reports changing and our code not being able to handle it.
One way to solve it would be to match localstorage state with what the report gives out on first render and then prune renamed/deleted filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoneUE @Gustav-Eikaas