Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: rename phase -> phasenum #1191

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil changed the title P num refact: rename phase -> phasenum Nov 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 29.78723% with 33 lines in your changes missing coverage. Please review.

Project coverage is 40.63%. Comparing base (6564c83) to head (f921ffa).

Files with missing lines Patch % Lines
...c/main/java/neqsim/thermo/system/SystemThermo.java 20.00% 23 Missing and 1 partial ⚠️
...ilibrium/LinearProgrammingChemicalEquilibrium.java 62.50% 2 Missing and 1 partial ⚠️
...lowsolver/stirredcellsolver/StirredCellSolver.java 0.00% 3 Missing ⚠️
...namicoperations/flashops/CalcIonicComposition.java 0.00% 2 Missing ⚠️
src/main/java/neqsim/thermo/phase/PhasePCSAFT.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1191      +/-   ##
============================================
+ Coverage     39.59%   40.63%   +1.03%     
  Complexity     5869     5869              
============================================
  Files           717      717              
  Lines         69703    67921    -1782     
  Branches       8117     8091      -26     
============================================
- Hits          27601    27600       -1     
+ Misses        40441    38660    -1781     
  Partials       1661     1661              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good update

@asmfstatoil asmfstatoil merged commit 4ad8c72 into equinor:master Nov 23, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the pNum branch November 23, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants