Fix flaky test_to_from_pandas #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
reviewed
Sep 2, 2024
python/tests/rd_tests/test_rd_sum.py
Outdated
| # round to hours | ||
| roundtrip.index = roundtrip.index.round(freq="H") | ||
| baseline.index = baseline.index.round(freq="H") | ||
| # round to days |
There was a problem hiding this comment.
Could we leave an explanation here for why we round (so much). Related to some int32 handling of dates?
There was a problem hiding this comment.
Sure, its because there is so much conversion.
There was a problem hiding this comment.
Forgot to push, is updated now.
eivindjahren
force-pushed
the
fix_flaky_test
branch
from
e3c31c7
to
b35c7fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky test https://github.com/equinor/resdata/actions/runs/10628849221/job/29464486920