Why does the setup run Taiga after installation only when in silent mode?

[sorashi]

https://github.com/erengy/taiga/blob/bd2be25b62461c7eb49d8403f2b65e03e73d7dfb/setup/Taiga.nsi#L236-L240C12

Is this a mistake? Shouldn't it be configured like SaveInstDir above it? IfSilent 0 +2.

Currently, the setup runs the application only if the setup is run in silent mode with the /S flag.

I don't know whether this is intended behavior, so I'm not making an issue yet. Maybe you have a good reason for it :)

I'm asking because of this issue in a package I maintain, for reference: sorashi/chocolatey-packages#2

[soredake]

I think i understand now why is this happening. Taiga is meant to be always-running application, so starting it after installation is good thing, but as i understand installer does not check if taiga is running before installation or is it installed so it starts it in fresh silent installation too.

[erengy]

Silent mode is used by Taiga's updater here:

taiga/src/taiga/update.cpp

Lines 263 to 266 in b6f440e

	// /S runs the installer silently, /D overrides the default installation
	// directory. Do not rely on the current directory here, as it isn't
	// guaranteed to be the same as the module path.
	std::wstring parameters = L"/S /D=" + GetPathOnly(app.GetModulePath());

The process works as following:

• User agrees to upgrade Taiga to its latest version.
• Taiga downloads the installer and executes it using /S and /D flags.
• Installer sends a WM_DESTROY message to Taiga and waits 3 seconds for Taiga to close.
  (Correction: In silent mode, installer skips sending the message.)
• Installer silently extracts the files and restarts Taiga for a seamless upgrade.

This has been the case since 35342e5, for about ten years now. I didn't think of any other use case for the /S flag at the time. In retrospect, I should have probably used an additional parameter to restart the application.