Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusable in modular Java projects #242

Open
satsen opened this issue Oct 10, 2024 · 0 comments
Open

Unusable in modular Java projects #242

satsen opened this issue Oct 10, 2024 · 0 comments

Comments

@satsen
Copy link
Contributor

satsen commented Oct 10, 2024

Since no module-info exists, nor does an Automatic-Module-Name exist in the MANIFEST.MF, the generated name of this library becomes "ergo.appkit.2.12" which is an invalid name because no part of it can start with a number.

Unfortunately, fixing that will not be enough because the dependencies of this library also do not come with a module name and result in invalid names being generated due to the strange library_2.12 format used by Scala.

However, that does not mean that appkit should not have an Automatic-Module-Name. For example, the scala standard library comes with one (scala.library).

The first step to rectifying this problem is to add an Automatic-Module-Name to appkit. It should be named org.ergoplatform.appkit in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant