Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement modular arithmetic operations #415

Closed
kushti opened this issue Mar 6, 2019 · 2 comments
Closed

Implement modular arithmetic operations #415

kushti opened this issue Mar 6, 2019 · 2 comments
Labels
soft-fork Implementation requires soft-fork
Milestone
v6.0

Comments

@kushti
Copy link
Member

kushti commented Mar 6, 2019

The following test is failing, though #324 is done:

// TODO: enable after #324 is done
property("modular arithmetic ops") {

it's failing with:

Don't know how to evalNode(ModQ(Select(IntConstant(10),toBigInt,Some(SBigInt))))
sigmastate.lang.exceptions.CosterException: Don't know how to evalNode(ModQ(Select(IntConstant(10),toBigInt,Some(SBigInt))))
@kushti kushti added this to the Testnet2 milestone Mar 6, 2019
kushti added a commit that referenced this issue Mar 6, 2019
@kushti
failing test for issue #415
aba66e8
@kushti kushti assigned aslesarenko and unassigned ergomorphic Mar 10, 2019
@aslesarenko aslesarenko modified the milestones: Testnet2, Mainnet Mar 14, 2019
@aslesarenko aslesarenko modified the milestones: Testnet2, Mainnet Apr 3, 2019
@aslesarenko aslesarenko assigned greenhat and unassigned aslesarenko Apr 3, 2019
@aslesarenko aslesarenko added the soft-fork Implementation requires soft-fork label May 7, 2019
@aslesarenko aslesarenko modified the milestones: Mainnet, After Mainnet May 7, 2019
@greenhat greenhat mentioned this issue May 7, 2019
Merged
@aslesarenko aslesarenko changed the title Costing not working for modular arithmetic Implement modular arithmetic operations May 7, 2019
@greenhat
Copy link
Member

greenhat commented May 7, 2019

Fixed in #488

@greenhat greenhat closed this as completed May 7, 2019
@greenhat greenhat reopened this May 7, 2019
@greenhat
Copy link
Member

greenhat commented May 7, 2019

Closed in favor of #327

@greenhat greenhat closed this as completed May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
soft-fork Implementation requires soft-fork
Projects
None yet
Milestone
v6.0
Development

No branches or pull requests
4 participants
@greenhat @aslesarenko @kushti @ergomorphic