Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SubstContants: serialize ErgoTree size #994

Open
aslesarenko opened this issue May 21, 2024 · 0 comments · Fixed by #995
Open

Fix SubstContants: serialize ErgoTree size #994

aslesarenko opened this issue May 21, 2024 · 0 comments · Fixed by #995
Assignees
@aslesarenko
Labels
A-consensus Area: Code used in consensus (i.e. transaction validation) C-feature Category: Feature request or PR soft-fork Implementation requires soft-fork
Milestone
v6.0

Comments

@aslesarenko
Copy link
Member

This issue is to fix bug with SubstConstants operation noticed by @Luivatra.

"the ergoscript function substConstants does not include the size/contentlength uint in the output even if the input bytes have it defined"
@aslesarenko aslesarenko added soft-fork Implementation requires soft-fork A-consensus Area: Code used in consensus (i.e. transaction validation) C-feature Category: Feature request or PR labels May 21, 2024
@aslesarenko aslesarenko added this to the v6.0 milestone May 21, 2024
@aslesarenko aslesarenko self-assigned this May 21, 2024
@aslesarenko aslesarenko linked a pull request May 23, 2024 that will close this issue
[6.0] Fix SubstConstants: serialize ErgoTree size #995
Merged
@aslesarenko aslesarenko mentioned this issue May 23, 2024
Merged
@kushti kushti mentioned this issue Aug 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslesarenko aslesarenko

Labels
A-consensus Area: Code used in consensus (i.e. transaction validation) C-feature Category: Feature request or PR soft-fork Implementation requires soft-fork
Projects
None yet
Milestone
v6.0
Development

Successfully merging a pull request may close this issue.

[6.0] Fix SubstConstants: serialize ErgoTree size ergoplatform/sigmastate-interpreter
1 participant
@aslesarenko