Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build with Go 1.21 #7984

Closed
yorickdowne opened this issue Aug 9, 2023 · 9 comments
Closed

Support build with Go 1.21 #7984

yorickdowne opened this issue Aug 9, 2023 · 9 comments

Comments

@yorickdowne
Copy link

Implementation

The quic-go dependency would need to be updated from 0.33.0 to something more recent that supports Go 1.21, e.g. 0.37.3

Error message when building with Go 1.21 currently:

Building erigon
# github.com/quic-go/quic-go/internal/qtls
../../../go/pkg/mod/github.com/quic-go/quic-go@v0.33.0/internal/qtls/go121.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.21 yet. For more details, please see https://github.com/quic-go/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.21 yet. F...) as int value in variable declaration

quic-go from 0.37 on no longer requires its own TLS code, which means it should survive updates to the Go compiler far more easily:

"With the upcoming Go 1.21 release, we're now able to rely on the Go standard library's TLS implementation's QUIC support."

https://github.com/quic-go/quic-go/releases/tag/v0.37.0

@AskAlexSharov
Copy link
Collaborator

it dep from libp2p - maybe need update libp2p

@AskAlexSharov
Copy link
Collaborator

libp2p/go-libp2p#2488

@AskAlexSharov
Copy link
Collaborator

#8008

@AskAlexSharov
Copy link
Collaborator

blocked by libp2p/go-libp2p#2428 (comment)

@chenrui333
Copy link

blocked by libp2p/go-libp2p#2428 (comment)

FYI, v0.30.0 has shipped.

@AskAlexSharov
Copy link
Collaborator

blocked by #8078

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

This issue is stale because it has been open for 40 days with no activity. Remove stale label or comment, or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 7, 2023
@chenrui333
Copy link

can be closed via #8288

@github-actions github-actions bot removed the Stale label Oct 13, 2023
@yperbasis
Copy link
Member

Please re-open if the issue still happens with v2.59.2 or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants