Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Poetry installation in the PyPi workflow #919

Closed
miquelduranfrigola opened this issue Dec 19, 2023 · 6 comments · Fixed by #920
Closed

🐛 Bug: Poetry installation in the PyPi workflow #919

miquelduranfrigola opened this issue Dec 19, 2023 · 6 comments · Fixed by #920
Assignees
Labels
bug Something isn't working

Comments

@miquelduranfrigola
Copy link
Member

Describe the bug.

In trying to update Ersilia to PyPi using GitHub Actions, we get the following error: https://github.com/ersilia-os/ersilia/actions/runs/7259408946/job/19776488322

Describe the steps to reproduce the behavior

No response

Expected behavior.

No response

Screenshots.

No response

Operating environment

GitHub Actions

Additional context

No response

@miquelduranfrigola miquelduranfrigola added the bug Something isn't working label Dec 19, 2023
@DhanshreeA
Copy link
Member

The bug is introduced because the poetry installer script has been moved to a different location than the URL used in the workflow file. Ref: https://github.com/python-poetry/poetry#installation

As the tool has matured over time, the authors of Poetry recommend using a manual install with pip pinned to a specific version as part of CI recommendations. Ref: https://python-poetry.org/docs/#ci-recommendations
Creating a PR with the same.

@miquelduranfrigola
Copy link
Member Author

@DhanshreeA now we are getting this error. Should be an easy fix (twine not found): https://github.com/ersilia-os/ersilia/actions/runs/7260110067/job/19778596014

@GemmaTuron
Copy link
Member

This is now solved

@DhanshreeA
Copy link
Member

@GemmaTuron could we actually test this? I don't know how to test this other than to create a tag. 😅

@GemmaTuron
Copy link
Member

we actually want to make a new release because we have made many updates, so we could test it this way @miquelduranfrigola do you think?

@miquelduranfrigola
Copy link
Member Author

Yes, let me do a tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants