-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: [playground] Provide an option to reset to the default configuration #592
Comments
This seems helpful, I'm fine with this change. I'd like to know what other team members think. // @eslint/eslint-team |
Personally, I support this proposal 👍 I've often been the guy who was looking for that button, only to realize it wasn't there every time again. Even so, I'm aware of recommendations not to use reset buttons in forms for various reasons like this one, or this one from MDN (in the note), so I'd be interested in other opinions. |
👍 from me on the proposal in general, and also 👍 on @fasttime's comment that this should not fall into the common reset button accessibility traps. At the very least the solution should have an 'undo' option per https://www.w3.org/WAI/WCAG2/supplemental/patterns/o4p05-form-undo. |
Naming the button as "Revert to Default," "Clear Custom Configs," or "Restore to Recommended Configs" would be suitable? Users might misunderstand "Undo" as reverting the last action performed. |
What problem do you want to solve?
Currently, in the playground, if we modify some configurations and later wish to revert to the default settings, it can be challenging for the user to remember the newly added configurations and remove them correctly to return to the default Config.
For instance, if a user enables all the rules to check for all errors and then wants to revert to the default configuration, it will be very difficult for them.
What do you think is the correct solution?
We provide a 'Reset to Defaults' button in the UI, which restores the configuration to its default (initial) Configs.
Refs:
![Screenshot 2024-06-27 at 11 45 19 PM](https://private-user-images.githubusercontent.com/30730124/343907618-19e05551-0423-4a88-9896-2f26dcdbf5bf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI0NDMxNTgsIm5iZiI6MTcyMjQ0Mjg1OCwicGF0aCI6Ii8zMDczMDEyNC8zNDM5MDc2MTgtMTllMDU1NTEtMDQyMy00YTg4LTk4OTYtMmYyNmRjZGJmNWJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzMxVDE2MjA1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3N2JjNTdkZDhiZTFmYzU2Y2JmODdkZWNjZTg4NjZkMDdmNTViMjdkZTZiMGViNjFkYjAwYjZjOGIzMWQ1N2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.nBhArrk8tj1x8VM7GCs5eTgojXgQ3IF6oO5FsEMZpFk)
![Screenshot 2024-06-27 at 11 47 04 PM](https://private-user-images.githubusercontent.com/30730124/343907667-5f4b54b2-9430-4cdd-b36c-4c14cc27e02c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI0NDMxNTgsIm5iZiI6MTcyMjQ0Mjg1OCwicGF0aCI6Ii8zMDczMDEyNC8zNDM5MDc2NjctNWY0YjU0YjItOTQzMC00Y2RkLWIzNmMtNGMxNGNjMjdlMDJjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzMxVDE2MjA1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY3MmQxOWEyMjdlZmNlYWU0MDdmNGY3NjYyYmYwNmVlYzE1Yjg3OTYwMTc1YTYzY2NmM2UyYzU3ZTk0YmFhNjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.vdLEeiMAKfDkjdJuf0e3yeU4j71S58t2MdmiV5qYQGI)
Participation
Additional comments
We provide a 'Reset to Default' button in the UI similar to the below image. Open for any other suggestions also.
The text was updated successfully, but these errors were encountered: