From c67016dc053323d3d8943302cd6f281056740404 Mon Sep 17 00:00:00 2001 From: Bill Sacks Date: Thu, 12 Oct 2023 14:04:34 -0600 Subject: [PATCH] Remove a seemingly-unnecessary error check This error check was added in commit 7379b259f2d2d621e335204026b2e2644318772c (by Gerhard, Jan 12, 2018): "Add checks to prevent redist_arraycreate1de() from trying to redist an array where the index space is too small to span all PETs." Note that there is no error check like this in the case where we're not doing a redist, which makes me think that this may not be a fundamental PIO limitation. Furthermore, in a test program, it worked to remove this error check when writing and reading a 2x4 Field with 10 PETs (and going through the redist function). So it seems like this check isn't necessary. --- src/Infrastructure/IO/src/ESMCI_IO.C | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/Infrastructure/IO/src/ESMCI_IO.C b/src/Infrastructure/IO/src/ESMCI_IO.C index b9011f9778..667c6dd888 100644 --- a/src/Infrastructure/IO/src/ESMCI_IO.C +++ b/src/Infrastructure/IO/src/ESMCI_IO.C @@ -1297,15 +1297,6 @@ void IO::redist_arraycreate1de(Array *src_array_p, Array **dest_array_p, int pet distgridToArrayMap = &(distgridToArrayMapVec[0]); } - if (tileCount == 1) { - // FIXME(wjs, 2023-05-26) Generalize this error-check to work with the multi-tile case - if ((maxIndexPDimPTile[0]-minIndexPDimPTile[0]+1) minIndexInterface((int*)minIndexPDimPTile, ndims-replicatedDims);