Skip to content

Commit

Permalink
Add a comment about issues with I/O with replicated dimensions
Browse files Browse the repository at this point in the history
  • Loading branch information
billsacks committed Oct 11, 2023
1 parent c5f5961 commit de86430
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions src/Infrastructure/IO/src/ESMCI_IO.C
Original file line number Diff line number Diff line change
Expand Up @@ -1262,8 +1262,15 @@ void IO::redist_arraycreate1de(Array *src_array_p, Array **dest_array_p, int pet
std::vector<int> maxIndexPDimPTileVec;
std::vector<int> distgridToArrayMapVec;
if (replicatedDims>0){
// FIXME(wjs, 2023-05-26) Still need to fix this loop to work with the multi-tile
// case; then remove the following error check
// TODO(wjs, 2023-05-26) Still need to fix this loop to work with the multi-tile
// case; then remove the following error check.
//
// See commit 28f951b333 (reverted in c5f596127e) for an attempt to get this working
// in the multi-tile case. However, this attempt was aborted due to finding what
// appear to be issues with I/O with Arrays with replicated dimensions even in the
// single-tile case - see https://github.com/esmf-org/esmf/issues/184. We have decided
// to leave this functionality in place in case anyone is relying on it, but we do not
// expect I/O with Arrays with replicated dimensions to work reliably or consistently.
if (tileCount > 1) {
ESMC_LogDefault.MsgFoundError(ESMF_RC_NOT_IMPL,
"Multi-tile with > 1 DE per PET and replicated dims not yet implemented", ESMC_CONTEXT, rc);
Expand Down

0 comments on commit de86430

Please sign in to comment.