Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package downloaded README differ from the official one #7

Open
arabello opened this issue Apr 6, 2022 · 3 comments
Open

Package downloaded README differ from the official one #7

arabello opened this issue Apr 6, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@arabello
Copy link
Collaborator

arabello commented Apr 6, 2022

The jojo-gifs's README downloaded content differ its repository one for the same version (0.1.0).

@federico-terzi can you please give it a look? It might be related to the hub repository.

PS: I already tried to purge caches

@arabello arabello added the bug Something isn't working label Apr 6, 2022
@federico-terzi
Copy link
Contributor

Hey man :)

The readme is different because the package zip is generated from the copy hosted on the hub repo: https://github.com/espanso/hub/blob/main/packages/jojo-gifs/0.1.0/README.md

As part of the original migration, I've changed some readmes to adapt to the new format, and this is one of them. As a result, the original repo (homepage) still shows the old version

Do you see it as a major problem?

@arabello
Copy link
Collaborator Author

Thanks for the clarification. However, why adapting to the new format required changing this specific readme content?

Let me be specific: the package matches consist of imgur.com's URLs (HTML pages, e.g. https://imgur.com/yFsi2sj). The original readme shows per each match the corresponding GIF (e.g. https://i.imgur.com/yFsi2sj.gif), while the new readme sticks with the match's URL (HTML page, https://imgur.com/yFsi2sj). This breaks the readme rendering as the markdown image elements do not refer to images URLs.

@federico-terzi
Copy link
Contributor

@arabello Good point, this is surely a mistake from my side. I'll fix it soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants