Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customize NimBLE configs with MYNEWT_ prefix (IDFGH-14043) #14864

Open
Tnze opened this issue Nov 11, 2024 · 2 comments
Open

Allow customize NimBLE configs with MYNEWT_ prefix (IDFGH-14043) #14864

Tnze opened this issue Nov 11, 2024 · 2 comments
Assignees
Labels
Status: Selected for Development Issue is selected for development Type: Feature Request Feature request for IDF

Comments

@Tnze
Copy link

Tnze commented Nov 11, 2024

Is your feature request related to a problem?

I'm using NimBLE to create a BLE server with DIS service. It turns out that I have to enable following configs to have all characteristics in DIS.

  • MYNEWT_VAL_BLE_SVC_DIS_FIRMWARE_REVISION_READ_PERM
  • MYNEWT_VAL_BLE_SVC_DIS_HARDWARE_REVISION_READ_PERM
  • MYNEWT_VAL_BLE_SVC_DIS_SOFTWARE_REVISION_READ_PERM
  • MYNEWT_VAL_BLE_SVC_DIS_MANUFACTURER_NAME_READ_PERM

Describe the solution you'd like.

These configs are defined in "esp-idf\components\bt\host\nimble\port\include\esp_nimble_cfg.h", which (in my opinion) should not be modified directly.

I want some method to customize the configurations without modify esp-idf itself.

Describe alternatives you've considered.

No response

Additional context.

I found there were some issues for expose other NimBLE configs. I think it will be good to have a general way to expose all available configs.

@Tnze Tnze added the Type: Feature Request Feature request for IDF label Nov 11, 2024
@github-actions github-actions bot changed the title Allow customize NimBLE configs with MYNEWT_ prefix Allow customize NimBLE configs with MYNEWT_ prefix (IDFGH-14043) Nov 11, 2024
@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 11, 2024
@rahult-github
Copy link
Collaborator

Hi @Tnze ,

Exposing all configs to menuconfig will make the menuconfig way too clumsy, Instead we follow the path of identifying the options which are really useful to be modified and expose them to be configurable. We are in process of making this change internally. For the use case you mentioned,you can try the attached patch and check if it helps fix your issue.

0001-fix-nimble-Fixed-Device-Information-and-Scan-Paramet.txt

@Tnze
Copy link
Author

Tnze commented Nov 12, 2024

Thanks, I tested the patch and it works.

@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development and removed Status: Opened Issue is new labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Selected for Development Issue is selected for development Type: Feature Request Feature request for IDF
Projects
None yet
Development

No branches or pull requests

3 participants