Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks: Use std::hint::black_box() instead of criterion::black_box() #2121

Closed
AmmarAbouZor opened this issue Oct 20, 2024 · 1 comment
Closed
Assignees
Labels
new newly created issue

Comments

@AmmarAbouZor
Copy link
Member

AmmarAbouZor commented Oct 20, 2024

We can use the native black_box() function from rust since it's moved to stable since Rust version 1.66

Currently we are using the black_box() function from the crate 'criterion` which made as a workaround until the native function is stabilize.

The current implementation in master branch in criterion has already marked their function as deprecated for further releases link

We still need to consider what changes we can introduce to the mocks with this function to make the benchmarks more stable if possible

@AmmarAbouZor AmmarAbouZor self-assigned this Oct 20, 2024
@github-actions github-actions bot added the new newly created issue label Oct 20, 2024
@AmmarAbouZor
Copy link
Member Author

Done in #2131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new newly created issue
Projects
None yet
Development

No branches or pull requests

1 participant