Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cleanup Session Temporary Files #2137

Closed
AmmarAbouZor opened this issue Oct 28, 2024 · 0 comments · Fixed by #2142
Closed

Improve Cleanup Session Temporary Files #2137

AmmarAbouZor opened this issue Oct 28, 2024 · 0 comments · Fixed by #2142
Assignees
Labels
new newly created issue

Comments

@AmmarAbouZor
Copy link
Member

Chipmunk writes session temporary files to the directory tmp in chipmunk home directory, and those files seems to not be cleaned up always + attachment files never get cleaned up. Therefore, it would be better to consider some improvements on the cleaning up mechanism.
Here are some suggestions:

  • Remove session main file and the attachments directory on drop() method on Rust side, to ensure file will be cleaned up even on panics.
  • Move the temporary directory to the Operating system temporary directory, so at least they would get cleaned up once the user (or the operating system) cleaned up the temporary directory
  • Clean up the temp directory when chipmunk starts, but we need to solve the issue if multiple Chipmunk instance are running on the same device
  • Provide a function inside Chipmunk to clean up temporary data, but I don't know how affective this solution would be, because the user may never see or use such a function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new newly created issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants