Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to accommodate for '%' signs? #34

Open
hectorc90 opened this issue Aug 4, 2020 · 2 comments · May be fixed by #36
Open

Possible to accommodate for '%' signs? #34

hectorc90 opened this issue Aug 4, 2020 · 2 comments · May be fixed by #36
Assignees

Comments

@hectorc90
Copy link

Highlighting a snippet of text containing a percentage doesn't work with Twitter text share - would it be possible to accommodate for special characters? This would be particularly useful for content containing lots of stats.

@estevanmaito
Copy link
Owner

I'll look into it and try to make a non-breaking change.

This is where this problem happens https://github.com/estevanmaito/sharect/blob/master/src/Button/ShareButton/ShareButton.js#L6

@hectorc90
Copy link
Author

Thank you - that would great.

@nona-luypaert nona-luypaert linked a pull request May 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants