source-braintree-native: fix nullable key on full refresh resources

estuary · Dec 9, 2024 · 1c80e71 · 1c80e71
1 parent e637677
commit 1c80e71
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 63 deletions.
diff --git a/source-braintree-native/source_braintree_native/models.py b/source-braintree-native/source_braintree_native/models.py
@@ -70,7 +70,7 @@ class Advanced(BaseModel):
 
 
 class FullRefreshResource(BaseDocument, extra="allow"):
-    id: str | None
+    pass
 
 
 class IncrementalResource(BaseDocument, extra="allow"):

diff --git a/source-braintree-native/source_braintree_native/resources.py b/source-braintree-native/source_braintree_native/resources.py
@@ -96,13 +96,13 @@ def open(
                 gateway_property,
                 gateway_response_field,
             ),
-            tombstone=FullRefreshResource(_meta=FullRefreshResource.Meta(op="d"), id=None)
+            tombstone=FullRefreshResource(_meta=FullRefreshResource.Meta(op="d"))
         )
 
     return [
         common.Resource(
             name=name,
-            key=["/id"],
+            key=["/_meta/row_id"],
             model=FullRefreshResource,
             open=functools.partial(open, _create_gateway(config), gateway_property, gateway_response_field),
             initial_state=ResourceState(),

diff --git a/source-braintree-native/tests/snapshots/snapshots__discover__capture.stdout.json b/source-braintree-native/tests/snapshots/snapshots__discover__capture.stdout.json
@@ -40,28 +40,14 @@
             "row_id": -1
           },
           "description": "Document metadata"
-        },
-        "id": {
-          "anyOf": [
-            {
-              "type": "string"
-            },
-            {
-              "type": "null"
-            }
-          ],
-          "title": "Id"
         }
       },
-      "required": [
-        "id"
-      ],
       "title": "FullRefreshResource",
       "type": "object",
       "x-infer-schema": true
     },
     "key": [
-      "/id"
+      "/_meta/row_id"
     ]
   },
   {
@@ -105,28 +91,14 @@
             "row_id": -1
           },
           "description": "Document metadata"
-        },
-        "id": {
-          "anyOf": [
-            {
-              "type": "string"
-            },
-            {
-              "type": "null"
-            }
-          ],
-          "title": "Id"
         }
       },
-      "required": [
-        "id"
-      ],
       "title": "FullRefreshResource",
       "type": "object",
       "x-infer-schema": true
     },
     "key": [
-      "/id"
+      "/_meta/row_id"
     ]
   },
   {
@@ -170,28 +142,14 @@
             "row_id": -1
           },
           "description": "Document metadata"
-        },
-        "id": {
-          "anyOf": [
-            {
-              "type": "string"
-            },
-            {
-              "type": "null"
-            }
-          ],
-          "title": "Id"
         }
       },
-      "required": [
-        "id"
-      ],
       "title": "FullRefreshResource",
       "type": "object",
       "x-infer-schema": true
     },
     "key": [
-      "/id"
+      "/_meta/row_id"
     ]
   },
   {
@@ -235,28 +193,14 @@
             "row_id": -1
           },
           "description": "Document metadata"
-        },
-        "id": {
-          "anyOf": [
-            {
-              "type": "string"
-            },
-            {
-              "type": "null"
-            }
-          ],
-          "title": "Id"
         }
       },
-      "required": [
-        "id"
-      ],
       "title": "FullRefreshResource",
       "type": "object",
       "x-infer-schema": true
     },
     "key": [
-      "/id"
+      "/_meta/row_id"
     ]
   },
   {
-Original file line number
+Diff line change
@@ Expand Up / @@ -70,7 +70,7 @@ class Advanced(BaseModel): @@
     class FullRefreshResource(BaseDocument, extra="allow"):
-        id: str | None
+        pass
     class IncrementalResource(BaseDocument, extra="allow"):
@@ Expand Down @@