source-facebook-marketing: removing old tests

estuary · Nov 14, 2024 · 332d3ec · 332d3ec
1 parent e44b459
commit 332d3ec
Show file tree

Hide file tree

Showing 17 changed files with 61 additions and 2,130 deletions.
diff --git a/estuary-cdk/common.Dockerfile b/estuary-cdk/common.Dockerfile
@@ -1,5 +1,5 @@
 # syntax=docker/dockerfile:1
-FROM python:3.12-slim as base
+FROM python:3.11 as base
 FROM base as builder
 
 ARG CONNECTOR_NAME

diff --git a/source-facebook-marketing/test.flow.yaml b/source-facebook-marketing/test.flow.yaml
@@ -27,62 +27,62 @@ captures:
           cursorField:
             - updated_time
         target: acmeCo/ads
-      # - resource:
-      #     stream: ad_creatives
-      #     syncMode: full_refresh
-      #   target: acmeCo/ad_creatives
-      # - resource:
-      #     stream: ads_insights
-      #     syncMode: incremental
-      #     cursorField:
-      #       - date_start
-      #   target: acmeCo/ads_insights
-      # - resource:
-      #     stream: ads_insights_age_and_gender
-      #     syncMode: incremental
-      #     cursorField:
-      #       - date_start
-      #   target: acmeCo/ads_insights_age_and_gender
-      # - resource:
-      #     stream: ads_insights_country
-      #     syncMode: incremental
-      #     cursorField:
-      #       - date_start
-      #   target: acmeCo/ads_insights_country
-      # - resource:
-      #     stream: ads_insights_region
-      #     syncMode: incremental
-      #     cursorField:
-      #       - date_start
-      #   target: acmeCo/ads_insights_region
-      # - resource:
-      #     stream: ads_insights_dma
-      #     syncMode: incremental
-      #     cursorField:
-      #       - date_start
-      #   target: acmeCo/ads_insights_dma
-      # - resource:
-      #     stream: ads_insights_platform_and_device
-      #     syncMode: incremental
-      #     cursorField:
-      #       - date_start
-      #   target: acmeCo/ads_insights_platform_and_device
-      # - resource:
-      #     stream: ads_insights_action_type
-      #     syncMode: incremental
-      #     cursorField:
-      #       - date_start
-      #   target: acmeCo/ads_insights_action_type
+      - resource:
+          stream: ad_creatives
+          syncMode: full_refresh
+        target: acmeCo/ad_creatives
+      - resource:
+          stream: ads_insights
+          syncMode: incremental
+          cursorField:
+            - date_start
+        target: acmeCo/ads_insights
+      - resource:
+          stream: ads_insights_age_and_gender
+          syncMode: incremental
+          cursorField:
+            - date_start
+        target: acmeCo/ads_insights_age_and_gender
+      - resource:
+          stream: ads_insights_country
+          syncMode: incremental
+          cursorField:
+            - date_start
+        target: acmeCo/ads_insights_country
+      - resource:
+          stream: ads_insights_region
+          syncMode: incremental
+          cursorField:
+            - date_start
+        target: acmeCo/ads_insights_region
+      - resource:
+          stream: ads_insights_dma
+          syncMode: incremental
+          cursorField:
+            - date_start
+        target: acmeCo/ads_insights_dma
+      - resource:
+          stream: ads_insights_platform_and_device
+          syncMode: incremental
+          cursorField:
+            - date_start
+        target: acmeCo/ads_insights_platform_and_device
+      - resource:
+          stream: ads_insights_action_type
+          syncMode: incremental
+          cursorField:
+            - date_start
+        target: acmeCo/ads_insights_action_type
       - resource:
           stream: campaigns
           syncMode: incremental
           cursorField:
             - updated_time
         target: acmeCo/campaigns
-      # - resource:
-      #     stream: custom_conversions
-      #     syncMode: full_refresh
-      #   target: acmeCo/custom_conversions
+      - resource:
+          stream: custom_conversions
+          syncMode: full_refresh
+        target: acmeCo/custom_conversions
       - resource:
           stream: images
           syncMode: incremental

diff --git a/source-facebook-marketing/tests/conftest.py b/source-facebook-marketing/tests/conftest.py
diff --git a/source-facebook-marketing/tests/helpers.py b/source-facebook-marketing/tests/helpers.py
diff --git a/source-facebook-marketing/tests/snapshots/snapshots__discover__capture.stdout.json b/source-facebook-marketing/tests/snapshots/snapshots__discover__capture.stdout.json
@@ -38852,11 +38852,7 @@
       ]
     },
     "key": [
-      "/object_id",
-      "/actor_id",
-      "/application_id",
-      "/event_time",
-      "/event_type"
+      "/actor_id"
     ]
   },
   {

diff --git a/source-facebook-marketing/tests/snapshots/snapshots__spec__capture.stdout.json b/source-facebook-marketing/tests/snapshots/snapshots__spec__capture.stdout.json
@@ -5,14 +5,19 @@
       "title": "Source Facebook Marketing",
       "type": "object",
       "properties": {
-        "account_id": {
-          "title": "Account ID",
+        "account_ids": {
+          "title": "Account IDs",
           "description": "The Facebook Ad account ID to use when pulling data from the Facebook Marketing API. Open your Meta Ads Manager. The Ad account ID number is in the account dropdown menu or in your browser's address bar. See the <a href=\"https://www.facebook.com/business/help/1492627900875762\">docs</a> for more information.",
           "order": 0,
           "examples": [
             "111111111111111"
           ],
-          "type": "string"
+          "type": "array",
+          "items": {
+            "type": "string",
+            "pattern": "^[0-9]+$"
+          },
+          "uniqueItems": true
         },
         "start_date": {
           "title": "Start Date",
@@ -406,7 +411,7 @@
         }
       },
       "required": [
-        "account_id",
+        "account_ids",
         "start_date",
         "credentials"
       ]

diff --git a/source-facebook-marketing/tests/test_api.py b/source-facebook-marketing/tests/test_api.py