Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estuary-cdk: Add restart_interval override #1354

Closed
wants to merge 1 commit into from

Conversation

jshearer
Copy link
Contributor

@jshearer jshearer commented Mar 11, 2024

Description:

This allows connectors to override their target lifetime. The problem is that some connectors may have tasks that run for longer than the restart interval. Since the restart signal is soft, i.e all tasks are allowed to run to completion before the connector exits (but no new tasks will be started once the restart signal has been triggered), tasks running longer than the restart interval could effectively starve the shorter-running tasks.

Note: This does feel like kind of a band-aid fix, but I'm not thinking of a better option right now. Needing to restart at all feels like a bit of a smell... so maybe this should be paired with some logic to just never (voluntarily, we should still handle external exit requests properly) restart if not needed?

Also, ideally this would be hidden under an Advanced section, but I wasn't confident enough in my knowledge of Python OOP best practices to define a generic/abstract base BaseAdvanced class, and then have the abstract BaseEndpointConfig include it, while also allowing both to remain extendable by connector authors. If you feel strongly that it should be in Advanced then I'll go and figure this part out, if not I'm happy to leave it as is for now.


This change is Reviewable

… known long-running tasks to restart less frequently
@jshearer jshearer requested a review from jgraettinger March 11, 2024 16:57
@jgraettinger
Copy link
Member

I believe this is not desired, especially given the evolution of the NetSuite connector, and can be closed out.

@jshearer jshearer closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants